Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(react-spinbutton): slot input handler set value #33680

Open
wants to merge 7 commits into
base: master
Choose a base branch
from

Conversation

carlamntn
Copy link
Contributor

Previous Behavior

Adding an onInput listener to the input slot to handle more input cases results in the value not being set when the SpinButton is controlled.

New Behavior

The value gets updated

Related Issue(s)

Copy link

github-actions bot commented Jan 17, 2025

📊 Bundle size report

Package & Exports Baseline (minified/GZIP) PR Change
react-components
react-components: entire library
1.164 MB
291.433 kB
1.164 MB
291.455 kB
102 B
22 B
react-spinbutton
SpinButton
34.865 kB
11.639 kB
34.965 kB
11.661 kB
100 B
22 B
Unchanged fixtures
Package & Exports Size (minified/GZIP)
react-components
react-components: Button, FluentProvider & webLightTheme
69.236 kB
20.182 kB
react-components
react-components: Accordion, Button, FluentProvider, Image, Menu, Popover
222.641 kB
64.474 kB
react-components
react-components: FluentProvider & webLightTheme
44.473 kB
14.597 kB
react-portal-compat
PortalCompatProvider
8.39 kB
2.64 kB
react-timepicker-compat
TimePicker
108.551 kB
36.094 kB
🤖 This report was generated against 556fc8e7b9a921cedbb07c2f0670dfabcf8ec0ed

Copy link

Pull request demo site: URL

@carlamntn carlamntn marked this pull request as ready for review January 17, 2025 16:30
@carlamntn carlamntn requested a review from a team as a code owner January 17, 2025 16:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants