-
Notifications
You must be signed in to change notification settings - Fork 569
LogRecord and SpanByte changes #1186
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
TedHartMS
wants to merge
123
commits into
main
Choose a base branch
from
tedhar/storage-v2
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Move CountdownWrapper to its own file - Rename Lockable* to Transactional* - Rename Transient* to Ephemeral*
Other work to get CreateNewRecordRMW clean
…ns first pass done)
…onalOperation chain
…ail, and CopyToReadCache now being fully internal operations.
… no-longer-needed allocator functions that are now done by DLR
…n to DiskLogRecord
Almost done with Migrate changeover to LogRecord
…ync APIs) from Tsavorite
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an initial draft of a PR to convert Garnet to use a new ObjectAllocator with a revised on-disk format that will use only a single log file, change ISessionFunctions to be (Disk)LogRecord-based and propagate this to operations such as Compaction and Migration, remove TKey and TValue from TsavoriteKV, and many related refactors.
This PR will be long-lived as additional task PRs are merged into storage-v2 before it is ready for merge to main (see "Major Remaining Tasks" below). Currently this branch implements ONLY the in-memory portion; the IO work is not yet implemented.
Highlights:
(ReadOnly)Span<byte>
extensions.ReadOnlySpan<byte>
at the StorageSession and below, including Tsavorite. There are no longer any byte[] keys. The TKey type argument is gone from Tsavorite and Garnet.(ReadOnly)Span<byte>
or objects implementing IHeapObject. TValue has been removed from TsavoriteKV.Major remaining tasks (this will be updated as they are implemented):
(ReadOnly)Span<byte>
path by replacing byte* usage (such as was done for Utility.HashBytes).