[Issue 1191] Handle free list for revivification in RMW for expiration/deletes #1189
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TedHartMS
approved these changes
May 7, 2025
hamdaankhalid
changed the title
hamdaankhalid
changed the title
hamdaankhalid
commented
May 7, 2025
hamdaankhalid
commented
May 7, 2025
libs/storage/Tsavorite/cs/src/core/Index/Tsavorite/Implementation/Helpers.cs
Show resolved
Hide resolved
hamdaankhalid
commented
May 7, 2025
libs/storage/Tsavorite/cs/src/core/Index/Tsavorite/Implementation/InternalDelete.cs
Show resolved
Hide resolved
hamdaankhalid
commented
May 7, 2025
libs/storage/Tsavorite/cs/src/core/Index/Tsavorite/Implementation/InternalRMW.cs
Show resolved
Hide resolved
hamdaankhalid
commented
May 7, 2025
libs/storage/Tsavorite/cs/src/core/Index/Tsavorite/Implementation/InternalRMW.cs
Show resolved
Hide resolved
hamdaankhalid
commented
May 7, 2025
libs/storage/Tsavorite/cs/src/core/Index/Tsavorite/Implementation/InternalRMW.cs
Outdated
Show resolved
Hide resolved
hamdaankhalid
commented
May 7, 2025
libs/storage/Tsavorite/cs/src/core/Index/Tsavorite/Implementation/InternalRMW.cs
Outdated
Show resolved
Hide resolved
TedHartMS
reviewed
May 8, 2025
libs/storage/Tsavorite/cs/src/core/Allocator/SpanByteAllocator.cs
Outdated
Show resolved
Hide resolved
hamdaankhalid
commented
May 9, 2025
libs/storage/Tsavorite/cs/src/core/Index/Tsavorite/Implementation/InternalRMW.cs
Outdated
Show resolved
Hide resolved
hamdaankhalid
commented
May 9, 2025
libs/storage/Tsavorite/cs/src/core/Index/Tsavorite/Implementation/InternalRMW.cs
Show resolved
Hide resolved
hamdaankhalid
commented
May 9, 2025
libs/storage/Tsavorite/cs/src/core/Index/Tsavorite/Implementation/InternalRMW.cs
Show resolved
Hide resolved
hamdaankhalid
commented
May 9, 2025
libs/storage/Tsavorite/cs/src/core/Index/Tsavorite/Implementation/InternalRMW.cs
Outdated
Show resolved
Hide resolved
hamdaankhalid
commented
May 9, 2025
libs/storage/Tsavorite/cs/src/core/Index/Tsavorite/Implementation/InternalRMW.cs
Show resolved
Hide resolved
hamdaankhalid
changed the title
hamdaankhalid
force-pushed
the
hamdaankhalid/raise-records-back-to-life-like-phoenix-from-the-ashes
branch
from
e43cad9 to
130015c
Compare
…e-phoenix-from-the-ashes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
RMW does not allow for Free list Revivification when the code decides to either actively expire a key or delete (via expiration).
RMW can work off of the same semantics of when to perform elision of record from hybrid log as DELETE flow does. This PR refactors the code and moves logic into RMW as DELETE
New places of revivification:
When going via IPU and we find expired record we can tombstone and free list it.
When going via NCU we can potentially do complete elision, no new record, or do tombstone + old record elision.