Update default object store page size to 4k #1195
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update default object store page size to 4k. See discussion here: #1097 (comment) and the documentation here: https://microsoft.github.io/garnet/docs/getting-started/memory#log-size-object-store
Default object store page size of 1m is way too large, as memory is reclaimed in chunks of page-worth of objects. This PR will allow the
ObjectStoreHeapMemorySize
setting to reclaim heap space in reasonable granularity (around 170 objects at a time).