Open
Conversation
Redis rounds TTL seconds to the nearest integer (equivalent to (ms+500)/1000), while Garnet was truncating (flooring) via a direct (long) cast. This caused SET+EXPIRE 10+TTL to return 9 instead of 10 when called immediately. Fix: Use Math.Round(MidpointRounding.AwayFromZero) in both SecondsFromDiffUtcNowTicks and MillisecondsFromDiffUtcNowTicks in ConvertUtils.cs. Added TtlRoundingTest to verify string and object keys return the expected TTL value immediately after EXPIRE. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
Pull request overview
Align Garnet TTL/expiration remaining-time calculations with Redis’ rounding semantics, and add a regression test to prevent TTL off-by-one behavior immediately after setting an expiry.
Changes:
- Update tick-to-seconds and tick-to-milliseconds conversions to round to nearest integer (AwayFromZero) instead of truncating.
- Add a new test verifying TTL immediately after EXPIRE matches the requested TTL for both string and sorted set keys.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 5 comments.
| File | Description |
|---|---|
| test/Garnet.test/RespTests.cs | Adds a regression test covering TTL rounding behavior right after EXPIRE. |
| libs/common/ConvertUtils.cs | Changes remaining-time conversions to use rounding (vs truncation) to match Redis behavior. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Redis rounds TTL seconds to the nearest integer (equivalent to (ms+500)/1000), while Garnet was truncating (flooring) via a direct (long) cast. This caused SET+EXPIRE 10+TTL to return 9 instead of 10 when called immediately.
Fix: Use Math.Round(MidpointRounding.AwayFromZero) in both SecondsFromDiffUtcNowTicks and MillisecondsFromDiffUtcNowTicks in ConvertUtils.cs.
Added TtlRoundingTest to verify string and object keys return the expected TTL value immediately after EXPIRE.
Fixes #1389