Update unit 15 README.md to clarify retrieval options#1066
Merged
koreyspace merged 1 commit intoJan 12, 2026
Conversation
The passage defines "semantic search" and "vector search" as separate options, then immediately describes vector search in a way that makes it the implementation of semantic search. Then it defines "hybrid" as combining keyword and vector, but if semantic and vector were truly distinct, hybrid should be keyword + semantic + vector (three things), not two. The passage mixes two concepts: search purpose (lexical and semantic) and search implementation (keyword and vector). The proposed edit resolves this and makes clear that vector search is the alternative to keywoard search (in this list of options), and the reason one might use vector search is to perform a search based on semantics. This also resolves the issue with the hybrid option, which previously made it seem like hybrid didn't support semantic search as an option.
Contributor
|
👋 Thanks for contributing @mwarden! We will review the pull request and get back to you soon. |
BMHMOD
approved these changes
Dec 21, 2025
koreyspace
approved these changes
Jan 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The passage defines "semantic search" and "vector search" as separate options, then immediately describes vector search in a way that makes it the implementation of semantic search. Then it defines "hybrid" as combining keyword and vector, but if semantic and vector were truly distinct, hybrid should be keyword + semantic + vector (three things), not two.
The passage mixes two concepts: search purpose (lexical and semantic) and search implementation (keyword and vector).
The proposed edit resolves this and makes clear that vector search is the alternative to keywoard search (in this list of options), and the reason one might use vector search is to perform a search based on semantics. This also resolves the issue with the hybrid option, which previously made it seem like hybrid didn't support semantic search as an option.