Microsoft main#976
Closed
jyotirmoy-devops wants to merge 13 commits into
Closed
Conversation
Update files
Updating content
Pull everything
pull everything
with '#' will be ignored, and an empty message aborts the commit. On branch main Your branch is up to date with 'origin/main'. Changes to be committed: modified: .devcontainer/environment.yml modified: 06-text-generation-apps/python/aoai-app-recipe.py modified: 06-text-generation-apps/python/aoai-app.py modified: 07-building-chat-applications/python/aoai-assignment.ipynb modified: 08-building-search-applications/python/aoai-assignment.ipynb modified: 08-building-search-applications/python/aoai-solution.ipynb modified: 09-building-image-applications/python/aoai-app-variation.py modified: 09-building-image-applications/python/aoai-assignment.ipynb modified: 09-building-image-applications/python/aoai-solution.py deleted: 09-building-image-applications/python/generated-image.png new file: 09-building-image-applications/python/images/ch9-sol-generated-image.png new file: 09-building-image-applications/python/images/generated-image.png renamed: 09-building-image-applications/requirements.txt -> 09-building-image-applications/python/requirements.txt modified: 11-integrating-with-function-calling/python/aoai-assignment.ipynb modified: 15-rag-and-vector-databases/notebook-rag-vector-databases.ipynb renamed: requirements.txt -> 15-rag-and-vector-databases/requirements.txt
Contributor
|
👋 Thanks for contributing @jyotirmoy-devops! We will review the pull request and get back to you soon. |
Contributor
There was a problem hiding this comment.
Pull Request Overview
This pull request updates translations across multiple languages for the main README and lesson 9 files, reverting from newer translations to earlier versions and making various content improvements and corrections.
Key changes include:
- Updating translation metadata to use earlier versions with different original hash values and timestamps
- Improving content clarity, consistency, and accuracy across multiple language versions
- Standardizing terminology and correcting minor translation issues
Reviewed Changes
Copilot reviewed 44 out of 128 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
| translations/fr/README.md | Updates French translation with improved content structure and terminology consistency |
| translations/fr/09-building-image-applications/README.md | Revises French lesson 9 with clearer explanations and more natural language |
| translations/fi/README.md | Updates Finnish translation with better terminology and content improvements |
| translations/fi/09-building-image-applications/README.md | Improves Finnish lesson 9 with more natural language and better technical terms |
| translations/fa/README.md | Updates Persian translation with improved content flow and terminology |
| translations/fa/09-building-image-applications/README.md | Revises Persian lesson 9 with clearer technical explanations |
| translations/es/README.md | Updates Spanish translation with content improvements and terminology corrections |
| translations/es/09-building-image-applications/README.md | Improves Spanish lesson 9 with better technical language and clarity |
| translations/en/README.md | Updates English translation with minor content improvements |
| translations/en/09-building-image-applications/README.md | Revises English lesson 9 with improved explanations and formatting |
Files not reviewed (1)
- 11-integrating-with-function-calling/typescript/function-app/package-lock.json: Language not supported
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Comment on lines
+276
to
+278
| <img src="./images/mask.png" style="width: 30%; max-width: 200px; height: auto;"> | ||
| <img src="./images/sunlit_lounge_result.png" style="width: 30%; max-width: 200px; height: auto;"> |
There was a problem hiding this comment.
Image paths have been changed from translated_images/ to ./images/ directory. Verify that these image files exist in the local ./images/ directory to avoid broken links.
Comment on lines
+276
to
+278
| <img src="./images/sunlit_lounge.png" style="width: 30%; max-width: 200px; height: auto;"> | ||
| <img src="./images/mask.png" style="width: 30%; max-width: 200px; height: auto;"> | ||
| <img src="./images/sunlit_lounge_result.png" style="width: 30%; max-width: 200px; height: auto;"> |
There was a problem hiding this comment.
Image paths have been changed from translated_images/ to ./images/ directory. Verify that these image files exist in the local ./images/ directory to avoid broken links.
Comment on lines
+276
to
+278
| <img src="./images/sunlit_lounge.png" style="width: 30%; max-width: 200px; height: auto;"> | ||
| <img src="./images/mask.png" style="width: 30%; max-width: 200px; height: auto;"> | ||
| <img src="./images/sunlit_lounge_result.png" style="width: 30%; max-width: 200px; height: auto;"> |
There was a problem hiding this comment.
Image paths have been changed from translated_images/ to ./images/ directory. Verify that these image files exist in the local ./images/ directory to avoid broken links.
Suggested change
| <img src="./images/sunlit_lounge.png" style="width: 30%; max-width: 200px; height: auto;"> | |
| <img src="./images/mask.png" style="width: 30%; max-width: 200px; height: auto;"> | |
| <img src="./images/sunlit_lounge_result.png" style="width: 30%; max-width: 200px; height: auto;"> | |
| <img src="../../../translated_images/sunlit_lounge.png" style="width: 30%; max-width: 200px; height: auto;"> | |
| <img src="../../../translated_images/mask.png" style="width: 30%; max-width: 200px; height: auto;"> | |
| <img src="../../../translated_images/sunlit_lounge_result.png" style="width: 30%; max-width: 200px; height: auto;"> |
| <img src="./images/sunlit_lounge.png" style="width: 30%; max-width: 200px; height: auto;"> | ||
| <img src="./images/mask.png" style="width: 30%; max-width: 200px; height: auto;"> | ||
| <img src="./images/sunlit_lounge_result.png" style="width: 30%; max-width: 200px; height: auto;"> |
There was a problem hiding this comment.
Image paths have been changed from translated_images/ to ./images/ directory. Verify that these image files exist in the local ./images/ directory to avoid broken links.
Suggested change
| <img src="./images/sunlit_lounge_result.png" style="width: 30%; max-width: 200px; height: auto;"> | |
| <!-- <img src="./images/sunlit_lounge_result.png" style="width: 30%; max-width: 200px; height: auto;"> --> |
Comment on lines
+276
to
+278
| <img src="./images/mask.png" style="width: 30%; max-width: 200px; height: auto;"> | ||
| <img src="./images/sunlit_lounge_result.png" style="width: 30%; max-width: 200px; height: auto;"> |
There was a problem hiding this comment.
Image paths have been changed from translated_images/ to ./images/ directory. Verify that these image files exist in the local ./images/ directory to avoid broken links.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.