Conversation
damyanp
left a comment
damyanp
left a comment
There was a problem hiding this comment.
Couple of notes remaining from me.
|
Can someone please re-run the CLA thing? It should be resolved on my end. |
Please follow the instructions in the comment it posted. |
|
CLA bot should be pleased now? I should have been added. |
damyanp
left a comment
damyanp
left a comment
There was a problem hiding this comment.
Thanks, CLA bot seems happy now.
Will need the header updated and the text formatted to 80 columns before we can accept this.
The comment around tying it to cooperative vectors can take or leave for now.
Co-authored-by: Damyan Pepper <damyanp@microsoft.com>
damyanp
left a comment
damyanp
left a comment
There was a problem hiding this comment.
It looks like there are still some unresolved comments that need to be addressed before we can merge this.
|
Yep, I'll get on this in the coming days. Sorry for being a bit slow here :( |
|
No worries, and no rush - I've just been looking through old PRs, and this one looked like it might be waiting for me to review new changes which is why I added the note on the current state. |
damyanp
left a comment
damyanp
left a comment
There was a problem hiding this comment.
Thank you! This looks ready to merge and move on filing issues to track further feedback and work required on this proposal.
@llvm-beanz - as sponsor of this can you provide the 2nd review and shepherd this change in please?
3 participants
Allow
i8andu8types, which are useful for pre-processing/post-processing data used in cooperative matrix/vector operations. Right now it's really ugly to unpack/pack viai32. This proposal enablesi8andu8as native types in the shader core.