msft-preview: runtime: upgrade to CH v51.1#440
msft-preview: runtime: upgrade to CH v51.1#440Redent0r wants to merge 4 commits intomsft-previewfrom
Conversation
Regenerate CH client against v51.1 Signed-off-by: Saul Paredes <saulparedes@microsoft.com>
The recently-added nested property is true by default, but is not supported yet on MSHV. See cloud-hypervisor/cloud-hypervisor#7408 for additional information. Signed-off-by: Dan Mihai <dmihai@microsoft.com>
There was a problem hiding this comment.
Pull request overview
Updates the Cloud Hypervisor (CH) dependency and synchronizes the in-repo OpenAPI specs + generated Go client code to match CH v51.1, including a small runtime adjustment for MSHV compatibility.
Changes:
- Bump Cloud Hypervisor version reference to
v51.1inversions.yaml. - Update CH OpenAPI specs and regenerate the Go client to include new API surface (e.g.,
/vm.resize-disk) and new schema fields (CPUnested, disk image options, net offloads, NUMAdevice_id). - In
clh.go, disableCpusConfig.nestedwhen running with MSHV (/dev/mshvpresent).
Reviewed changes
Copilot reviewed 18 out of 18 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| versions.yaml | Updates tracked Cloud Hypervisor version to v51.1. |
| src/runtime/virtcontainers/pkg/cloud-hypervisor/cloud-hypervisor.yaml | Syncs embedded CH OpenAPI spec with v51.1 additions. |
| src/runtime/virtcontainers/pkg/cloud-hypervisor/client/api/openapi.yaml | Syncs client OpenAPI input spec with v51.1 additions. |
| src/runtime/virtcontainers/pkg/cloud-hypervisor/client/api_default.go | Regenerated client method for /vm.resize-disk. |
| src/runtime/virtcontainers/pkg/cloud-hypervisor/client/model_*.go | Regenerated models reflecting new schema fields. |
| src/runtime/virtcontainers/pkg/cloud-hypervisor/client/docs/*.md | Regenerated API/model documentation for new endpoint/model. |
| src/runtime/virtcontainers/pkg/cloud-hypervisor/client/README.md | Regenerated client README to list new API/model. |
| src/runtime/virtcontainers/pkg/cloud-hypervisor/client/.openapi-generator/FILES | Updates generator manifest to include new generated files. |
| src/runtime/virtcontainers/clh.go | Disables nested CPU option on MSHV and adds a helper to detect /dev/mshv. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Redent0r
changed the title
This cloud-hypervisor is a directory, so it needs "rm -rf" instead of "rm -f". Signed-off-by: Dan Mihai <dmihai@microsoft.com>
|
Came across https://github.com/microsoft/kata-containers/actions/runs/23915688184/job/69783643900?pr=440#step:5:419 , so cherry picked kata-containers@d8b4034 |
|
CI is failing required |
disable Kata Containers CI / kata-containers-ci-on-push / run-kata-deploy-tests / run-kata-deploy-tests (qemu, k3s) Signed-off-by: Saul Paredes <saulparedes@microsoft.com>
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 20 out of 20 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
See commits for details