Skip to content

Added fallback for MAXSEARCHRESULTS in RedisMemory:GetListAsync #1063

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Added fallback for MAXSEARCHRESULTS in RedisMemory:GetListAsync #1063

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d7d1c68
Added fallback for MAXSEARCHRESULTS in RedisMemory:GetListAsync
AnnoDeJong May 8, 2025
b3f8e93
Merge branch 'main' into issue-1062-fix-redis-memory-getlistasync-fal…
dluc May 9, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 15 additions & 9 deletions extensions/Redis/Redis/RedisMemory.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -281,28 +281,34 @@ public async IAsyncEnumerable<MemoryRecord> GetListAsync(string index, ICollecti
var numOfDocumentsFromEnd = -1 * (limit + 1);

var probingQueryTask = this._search.SearchAsync(normalizedIndexName, query);
var configurationCheckTask = this._search.ConfigGetAsync("MAXSEARCHRESULTS"); // need to query Max Search Results since Redis doesn't support unbounded queries.

// pull back in one round trip, hence the separated awaits.
var firstTripDocs = await probingQueryTask.ConfigureAwait(false);
var configurationResult = await configurationCheckTask.ConfigureAwait(false);

var docsNeeded = (int)firstTripDocs.TotalResults - numOfDocumentsFromEnd;

documents.AddRange(firstTripDocs.Documents.Take(docsNeeded));
if (docsNeeded > 10)
{
if (configurationResult.TryGetValue("MAXSEARCHRESULTS", out string? value) && int.TryParse(value, out var maxSearchResults))
int maxSearchResults = 10000; // Default value
try
{
limit = Math.Min(docsNeeded - 10, maxSearchResults);
query.Limit(10, limit);
var secondTripResults = await this._search.SearchAsync(normalizedIndexName, query).ConfigureAwait(false);
documents.AddRange(secondTripResults.Documents);
var configurationResult = await this._search.ConfigGetAsync("MAXSEARCHRESULTS").ConfigureAwait(false);
if (configurationResult.TryGetValue("MAXSEARCHRESULTS", out string? value) && int.TryParse(value, out var parsedValue))
{
maxSearchResults = parsedValue;
}
}
else // shouldn't be reachable.
catch (RedisServerException ex) when (ex.Message.Contains("unknown command", StringComparison.OrdinalIgnoreCase))
{
throw new RedisException("Redis does not contain a valid value for MAXSEARCHRESULTS, possible configuration issue in Redis.");
// Fallback to default value if FT.CONFIG is not supported
this._logger.LogWarning("FT.CONFIG command is not supported. Using default MAXSEARCHRESULTS value.");
}

limit = Math.Min(docsNeeded - 10, maxSearchResults);
query.Limit(10, limit);
var secondTripResults = await this._search.SearchAsync(normalizedIndexName, query).ConfigureAwait(false);
documents.AddRange(secondTripResults.Documents);
}
}
else
Expand Down