fix: performance issue with enum parsing during deserialization#670
Merged
fix: performance issue with enum parsing during deserialization#670
Conversation
This was referenced Mar 10, 2026
Closed
Signed-off-by: Vincent Biret <vibiret@microsoft.com>
baywet
force-pushed
the
perf/enum-deserialization
branch
from
cc5d273 to
4ff0582
Compare
adrian05-ms
previously approved these changes
Mar 11, 2026
* fix: avoid multiple strings allocations when deserializing flag enums Signed-off-by: Vincent Biret <vibiret@microsoft.com> * fix: avoid assigning parse nodes for collections of primitive values in json Signed-off-by: Vincent Biret <vibiret@microsoft.com> * fix: avoid allocation of parse nodes in form deserialization of collections Signed-off-by: Vincent Biret <vibiret@microsoft.com> * fix: further reduction of node assignments in cases where it's not necessary Signed-off-by: Vincent Biret <vibiret@microsoft.com> * fix: cleaner branching in loops to reduce padding Signed-off-by: Vincent Biret <vibiret@microsoft.com> --------- Signed-off-by: Vincent Biret <vibiret@microsoft.com>
![github-code-quality[bot]](https://avatars.githubusercontent.com/u/9919?s=60&v=4){kind=small}
Member
Author
|
@copilot the code coverage is low for the following methods, add some unit tests FormParseNode -> GetCollectionOfPrimitiveValues JsonParseNode -> GetScalarValue (Bool, Byte, SByte, ByteArray) |
Contributor
…lection methods (#684) * Initial plan * test: add missing unit tests for FormParseNode and JsonParseNode methods - Add long? support to FormParseNode.GetCollectionOfPrimitiveValues - Add private GetLongValue(string) helper to FormParseNode - Add GetCollectionOfLongPrimitiveValuesFromForm test - Add GetCollectionOfDateTimeOffsetPrimitiveValuesFromForm test - Add GetCollectionOfDatePrimitiveValuesFromForm test - Add JsonParseNode scalar tests: GetBoolValue, GetByteValue, GetSbyteValue, GetByteArrayValue - Add JsonParseNode GetCollectionOfEnumValues tests - Add JsonParseNode GetCollectionOfPrimitiveValues tests for bool?, byte?, sbyte?" Co-authored-by: baywet <7905502+baywet@users.noreply.github.com> * test: rename GetByteArrayValue test method to better reflect its intent Co-authored-by: baywet <7905502+baywet@users.noreply.github.com> --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: baywet <7905502+baywet@users.noreply.github.com>
Signed-off-by: Vincent Biret <vibiret@microsoft.com>
Signed-off-by: Vincent Biret <vibiret@microsoft.com>
adrian05-ms
approved these changes
Mar 19, 2026
|
This was referenced Mar 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
partial #632