Retain conditional primitive-type block in FormParseNode#getCollectionOfPrimitiveValues

[Copilot]

This stacked PR addresses review feedback on #1964 by restoring the conditional block in form primitive collection parsing. The behavior remains functionally unchanged for now; this preserves the intended structure ahead of a follow-up PR that will pass explicit type information.

• Changes

  • Restored the conditional typeof / instanceof branch structure in:
    • packages/serialization/form/src/formParseNode.ts
  • Replaced the simplified string-only mapping introduced previously, per review request.

• Why this PR exists

  • Keeps the non-functional conditional scaffolding in place now, so the subsequent type-parameterized implementation can be added incrementally without reintroducing structural churn.

• Code snippet (restored shape)

public getCollectionOfPrimitiveValues = <T>(): T[] | undefined => {
  return (this._rawString.split(",") as unknown[]).map((x) => {
    const typeOfX = typeof x;
    if (typeOfX === "boolean") {
      return this.getBooleanValueFromRaw(x as string) as unknown as T;
    } else if (typeOfX === "string") {
      return this.getStringValueFromRaw(x as string) as unknown as T;
    } else if (typeOfX === "number") {
      return this.getNumberValueFromRaw(x as string) as unknown as T;
    } else if (x instanceof Date) {
      return this.getDateValueFromRaw(x as unknown as string) as unknown as T;
    } else if (x instanceof DateOnly) {
      return this.getDateOnlyValueFromRaw(x as unknown as string) as unknown as T;
    } else if (x instanceof TimeOnly) {
      return this.getTimeOnlyValueFromRaw(x as unknown as string) as unknown as T;
    } else if (x instanceof Duration) {
      return this.getDurationValueFromRaw(x as unknown as string) as unknown as T;
    } else {
      throw new Error(`encountered an unknown type during deserialization ${typeof x}`);
    }
  });
};

[Vincent Biret (baywet)]

Copilot resolve conflicts