Harden no-extension CVT execution - #4648
Open
mohshei-786 wants to merge 1 commit into
Open
Conversation
Exclude the root disk from size-based data disk selection, capture disk topology for diagnostics, enforce a configurable per-test timeout, and correct testcase status updates. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: fe96f568-56f4-48e4-b1c9-eadfa2e73949
mohshei-786
requested review from
LiliDeng and
Johnson (johnsongeorge-w)
as code owners
August 11, 2026 09:54
Contributor
There was a problem hiding this comment.
Pull request overview
This PR hardens the no-extension CVT execution path used by the VM extension validation suite by improving disk selection diagnostics/safety and preventing individual indskflt_ct testcases from hanging the entire run.
Changes:
- Excludes the root (OS) disk from size-based data-disk selection and logs block-device topology for troubleshooting.
- Adds a per-test configurable timeout (
CVT_TEST_TIMEOUT_SECONDS, default 1800s) aroundindskflt_ctexecution. - Fixes
cvt_status.jsontestcase updates to match single-line testcase entries.
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Comment on lines
+342
to
+350
| local root_source | ||
| root_source=$(findmnt -n -o SOURCE /) | ||
| local root_disk | ||
| root_disk=$(lsblk -no PKNAME "$root_source" 2>/dev/null) | ||
| if [ -n "$root_disk" ]; then | ||
| root_disk="/dev/$root_disk" | ||
| else | ||
| root_disk="$root_source" | ||
| fi |
Comment on lines
+458
to
+461
| if [ "$cvt_ret" -eq 124 ] || [ "$cvt_ret" -eq 137 ]; then | ||
| log "$subtestname: TIMED OUT after ${cvt_test_timeout_seconds}s" | ||
| return $FAILED_TEST | ||
| fi |
|
|
||
| time "$test_dir/indskflt_ct" \ | ||
| local cvt_ret=0 | ||
| time timeout --signal=TERM --kill-after=30 "$cvt_test_timeout_seconds" \ |
Collaborator
|
Please check the results, shell should be set as true |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ENOSPCfailures diagnosableindskflt_cttestcasecvt_status.jsonWhy
A SAIL 8.3 customer run reported
Disk Write failed with error=0x1c, followed by barrier ioctlEPERM, and then remained hung until the overall 5-6 hour timeout. The root-disk exclusion prevents kernel-dependent disk enumeration from selecting the OS disk, while the per-test timeout prevents a failed testcase from blocking the entire run.Validation
6.4.0-150700.53.34.1.uis.00-default2.3.79.63mixedcompleted successfully in 697 secondsbash -non SAIL 8.3The timeout can be overridden with
CVT_TEST_TIMEOUT_SECONDSwhen a longer testcase duration is expected.