Fix/hibernation transient retry

[Sandygit01]

Description

Skip hibernation tests on FIPS-enabled kernels (Azure returns VMHibernateFailed on every attempt, so it is an unmet precondition rather than a failure), and treat a missing /proc/sys/crypto/fips_enabled as FIPS-disabled instead of erroring. Also reboot after hibernation setup so the bootloader resume=/resume_offset= parameters take effect before hibernating.

Related Issue

Type of Change

• Bug fix
• New feature
• Breaking change
• Refactoring
• Documentation update

Checklist

• Description is filled in above
• No credentials, secrets, or internal details are included
• Peer review requested (if not, add required peer reviewers after raising PR)
• Tests executed and results posted below

Test Validation

Key Test Cases:
verify_hibernation

Impacted LISA Features:
StartStop

Tested Azure Marketplace Images:

• redhat rhel 9_5 latest
• canonical 0001-com-ubuntu-server-jammy 22_04-lts-gen2 latest
• debian debian-12 12-gen2 latest

Test Results

Image	VM Size	Result
		PASSED / FAILED / SKIPPED

[Copilot]

Pull request overview

This PR updates the Azure hibernation test common helpers to (1) treat FIPS-enabled kernels as an unmet precondition (skip) and (2) reboot after hibernation setup on additional distros (Debian/Ubuntu) to avoid a known “accepts uevent but never suspends” failure mode.

Changes:

• Add FIPS-kernel detection and skip logic for Azure hibernation scenarios that always fail with VMHibernateFailed.
• Expand the post-setup reboot guard to include Debian and Ubuntu.

---

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

[Copilot]

Pull request overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated no new comments.

Suppressed comments (2)

lisa/microsoft/testsuites/power/common.py:36

• Please add a description explaining what this PR does and why (the PR description still contains the unfilled template placeholders).

# Some Azure guest/kernel combinations, including certified FIPS kernels,
# do not support hibernation at all. In those cases the platform returns
# VMHibernateFailed on every attempt, so we treat it as an unmet precondition
# rather than a transient failure that can be recovered with retry delay.
_HIBERNATE_FAILED_MARKER = "VMHibernateFailed"

lisa/microsoft/testsuites/power/common.py:172

• type(node.os) in (...) is unnecessarily strict and inconsistent with other checks in this module (e.g. isinstance(node.os, Redhat) above). Using isinstance is more robust and keeps behavior the same for the current OS classes.

    if type(node.os) in (Redhat, AlmaLinux, SLES, Debian, Ubuntu):

[LiliDeng]

AI Test Case Selection

Selected 10 test case(s): verify_hibernation_synthetic_network,verify_hibernation_sriov_network,verify_hibernation_time_sync,verify_hibernation_with_network_workload,verify_hibernation_with_storage_workload,verify_hibernation_with_memory_workload,verify_hibernation_synthetic_network_max_nics,verify_hibernation_sriov_network_max_nics,verify_hibernation_max_data_disks,verify_hibernation_with_vm_extension

Marketplace image: suse sles-15-sp6 gen2 latest

Result: Failed

View full logs in Azure DevOps

[microsoft-github-policy-service]

Sandygit01 please read the following Contributor License Agreement(CLA). If you agree with the CLA, please reply with the following information.

@microsoft-github-policy-service agree [company="{your company}"]

Options:

• (default - no company specified) I have sole ownership of intellectual property rights to my Submissions and I am not making Submissions in the course of work for my employer.

@microsoft-github-policy-service agree

• (when company given) I am making Submissions in the course of work for my employer (or my employer has intellectual property rights in my Submissions by contract or applicable law). I have permission from my employer to make Submissions and enter into this Agreement on behalf of my employer. By signing below, the defined term “You” includes me and my employer.

@microsoft-github-policy-service agree company="Microsoft"

Contributor License Agreement

Contribution License Agreement

This Contribution License Agreement (“Agreement”) is agreed to by the party signing below (“You”),
and conveys certain license rights to Microsoft Corporation and its affiliates (“Microsoft”) for Your
contributions to Microsoft open source projects. This Agreement is effective as of the latest signature
date below.

1. Definitions.
   “Code” means the computer software code, whether in human-readable or machine-executable form,
   that is delivered by You to Microsoft under this Agreement.
   “Project” means any of the projects owned or managed by Microsoft and offered under a license
   approved by the Open Source Initiative (www.opensource.org).
   “Submit” is the act of uploading, submitting, transmitting, or distributing code or other content to any
   Project, including but not limited to communication on electronic mailing lists, source code control
   systems, and issue tracking systems that are managed by, or on behalf of, the Project for the purpose of
   discussing and improving that Project, but excluding communication that is conspicuously marked or
   otherwise designated in writing by You as “Not a Submission.”
   “Submission” means the Code and any other copyrightable material Submitted by You, including any
   associated comments and documentation.
2. Your Submission. You must agree to the terms of this Agreement before making a Submission to any
   Project. This Agreement covers any and all Submissions that You, now or in the future (except as
   described in Section 4 below), Submit to any Project.
3. Originality of Work. You represent that each of Your Submissions is entirely Your original work.
   Should You wish to Submit materials that are not Your original work, You may Submit them separately
   to the Project if You (a) retain all copyright and license information that was in the materials as You
   received them, (b) in the description accompanying Your Submission, include the phrase “Submission
   containing materials of a third party:” followed by the names of the third party and any licenses or other
   restrictions of which You are aware, and (c) follow any other instructions in the Project’s written
   guidelines concerning Submissions.
4. Your Employer. References to “employer” in this Agreement include Your employer or anyone else
   for whom You are acting in making Your Submission, e.g. as a contractor, vendor, or agent. If Your
   Submission is made in the course of Your work for an employer or Your employer has intellectual
   property rights in Your Submission by contract or applicable law, You must secure permission from Your
   employer to make the Submission before signing this Agreement. In that case, the term “You” in this
   Agreement will refer to You and the employer collectively. If You change employers in the future and
   desire to Submit additional Submissions for the new employer, then You agree to sign a new Agreement
   and secure permission from the new employer before Submitting those Submissions.
5. Licenses.

• Copyright License. You grant Microsoft, and those who receive the Submission directly or
  indirectly from Microsoft, a perpetual, worldwide, non-exclusive, royalty-free, irrevocable license in the
  Submission to reproduce, prepare derivative works of, publicly display, publicly perform, and distribute
  the Submission and such derivative works, and to sublicense any or all of the foregoing rights to third
  parties.
• Patent License. You grant Microsoft, and those who receive the Submission directly or
  indirectly from Microsoft, a perpetual, worldwide, non-exclusive, royalty-free, irrevocable license under
  Your patent claims that are necessarily infringed by the Submission or the combination of the
  Submission with the Project to which it was Submitted to make, have made, use, offer to sell, sell and
  import or otherwise dispose of the Submission alone or with the Project.
• Other Rights Reserved. Each party reserves all rights not expressly granted in this Agreement.
  No additional licenses or rights whatsoever (including, without limitation, any implied licenses) are
  granted by implication, exhaustion, estoppel or otherwise.

6. Representations and Warranties. You represent that You are legally entitled to grant the above
   licenses. You represent that each of Your Submissions is entirely Your original work (except as You may
   have disclosed under Section 3). You represent that You have secured permission from Your employer to
   make the Submission in cases where Your Submission is made in the course of Your work for Your
   employer or Your employer has intellectual property rights in Your Submission by contract or applicable
   law. If You are signing this Agreement on behalf of Your employer, You represent and warrant that You
   have the necessary authority to bind the listed employer to the obligations contained in this Agreement.
   You are not expected to provide support for Your Submission, unless You choose to do so. UNLESS
   REQUIRED BY APPLICABLE LAW OR AGREED TO IN WRITING, AND EXCEPT FOR THE WARRANTIES
   EXPRESSLY STATED IN SECTIONS 3, 4, AND 6, THE SUBMISSION PROVIDED UNDER THIS AGREEMENT IS
   PROVIDED WITHOUT WARRANTY OF ANY KIND, INCLUDING, BUT NOT LIMITED TO, ANY WARRANTY OF
   NONINFRINGEMENT, MERCHANTABILITY, OR FITNESS FOR A PARTICULAR PURPOSE.
7. Notice to Microsoft. You agree to notify Microsoft in writing of any facts or circumstances of which
   You later become aware that would make Your representations in this Agreement inaccurate in any
   respect.
8. Information about Submissions. You agree that contributions to Projects and information about
   contributions may be maintained indefinitely and disclosed publicly, including Your name and other
   information that You submit with Your Submission.
9. Governing Law/Jurisdiction. This Agreement is governed by the laws of the State of Washington, and
   the parties consent to exclusive jurisdiction and venue in the federal courts sitting in King County,
   Washington, unless no federal subject matter jurisdiction exists, in which case the parties consent to
   exclusive jurisdiction and venue in the Superior Court of King County, Washington. The parties waive all
   defenses of lack of personal jurisdiction and forum non-conveniens.
10. Entire Agreement/Assignment. This Agreement is the entire agreement between the parties, and
    supersedes any and all prior agreements, understandings or communications, written or oral, between
    the parties relating to the subject matter hereof. This Agreement may be assigned by Microsoft.

[Copilot]

Pull request overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated no new comments.

Suppressed comments (2)

lisa/microsoft/testsuites/power/common.py:55

• Update the call site to use the renamed helper so the skip check continues to work.

    if _is_fips_kernel(node):

lisa/microsoft/testsuites/power/common.py:43

• The helper name _is_fips_kernel is misleading because it returns true when either the kernel or the runtime FIPS mode is enabled (/proc/sys/crypto/fips_enabled == 1). Renaming it to reflect both conditions will make the precondition clearer.

This issue also appears on line 55 of the same file.

def _is_fips_kernel(node: Node) -> bool:
    # Azure hibernation is unsupported on the certified FIPS kernel (e.g. Ubuntu
    # Pro *-azure-fips): it returns VMHibernateFailed on every attempt, so this
    # is an unmet precondition rather than a test failure.
    fips_enabled = "0"

[LiliDeng]

Hibernation on x86 systems failed in FIPS mode (fips=1) because it used MD5 for E820 memory-map integrity checks, which is prohibited in FIPS. The Linux kernel fixed this upstream by replacing MD5 with CRC32, allowing hibernation to function correctly under FIPS restrictions.