Open
Conversation
hippogr
force-pushed
the
ruigao/add-gpu-tag-node
branch
from
dfa6099 to
1b5d18f
Compare
There was a problem hiding this comment.
Pull request overview
This PR adds GPU vendor tagging functionality to differentiate between NVIDIA and AMD GPU nodes, and implements nodeSelector constraints in device plugin deployments to prevent errors when devices are not present.
Changes:
- Added
vendor=nvidiaandvendor=amdnode labels based on GPU type detection - Added nodeSelector to nvidia-device-plugin and amd-device-plugin DaemonSet deployments
- Implemented vendor labeling logic for worker nodes including fallback values for unknown GPU types and CPU-only nodes
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
| src/device-plugin/deploy/start.sh.template | Adds nodeSelector with vendor labels to NVIDIA and AMD GPU device plugin deployments |
| src/cluster-configuration/deploy/start.sh.template | Implements node labeling logic to assign vendor tags based on computing device type |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
hippogr
force-pushed
the
ruigao/add-gpu-tag-node
branch
from
1b5d18f to
90e25b2
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add tag vendor=nvidia and vendor=amd for nodes with different types of GPUs and add nodeSelector when deploying nvidia-device-plugin and amd-device-plugin to remove complaints with no GPUs in device plugin containers.