Fix model_info bug blocking Ollama model configs - #207
Merged
Conversation
model_info was not being set in the correct place. It was being set at ModelConfig.model_info when it should have been at ModelConfig.config.model_info This fixes issue #206
husseinmozannar
approved these changes
Jun 19, 2025
Contributor
|
thanks so much for cleaning this up! |
stefanoamorelli
pushed a commit
to stefanoamorelli/magentic-ui
that referenced
this pull request
Jun 29, 2025
Co-authored-by: Tyler Payne <tylerpayne@microsoft.com> Co-authored-by: Hussein Mozannar <hssein.mzannar@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
model_info was not being set in the correct place. It was being set at
ModelConfig.model_infowhen it should have been atModelConfig.config.model_infoI also updated the advanced defaults and provided zod schemas for the expected ModelInfo schema from autogen 0.6.1
This fixes issue #206