Skip to content

Fix max retries nesting in config example - #560

Closed
shi-weili wants to merge 1 commit into
mainfrom
shi-weili-fix-model-config-max-retries
Closed

Fix max retries nesting in config example#560
shi-weili wants to merge 1 commit into
mainfrom
shi-weili-fix-model-config-max-retries

Conversation

@shi-weili

Copy link
Copy Markdown
Collaborator

Related Issue

N/A

Summary

Fix the model client examples so max_retries is passed as client configuration instead of as a top-level component field.

Changes

  • Move max_retries: 5 under config for the OmniAgent, Fara, and Azure model client examples in config.yaml.example.

How to Verify

  1. Run uv run python -c 'import yaml; data = yaml.safe_load(open("config.yaml.example")); keys = ("model_config_omni", "model_config_fara", "model_config_azure_example"); assert all(data[key]["config"]["max_retries"] == 5 and "max_retries" not in data[key] for key in keys)'.
  2. Confirm git diff main...HEAD -- config.yaml.example contains only the three indentation changes.

Checklist

  • Tests added or updated (if applicable)
  • Documentation updated (if needed)
  • Verified using the steps above

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Copilot-Session: 23403cce-77eb-436e-a52c-4e9d5e36b0bc
@shi-weili shi-weili closed this Jul 22, 2026
@shi-weili
shi-weili deleted the shi-weili-fix-model-config-max-retries branch July 22, 2026 18:31
@shi-weili

Copy link
Copy Markdown
Collaborator Author

Replaced by #562 after renaming the head branch to fix/model-config-max-retries.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant