Don't return undefined when an empty model is passed to makerjs.measure.modelExtents#625
Merged
Merged
Conversation
Contributor
Author
|
It might be better to return |
Contributor
|
Thanks for the PR! function alwaysMeasureModel(model) {
return makerjs.measure.modelExtents(model) || { width: 0, height: 0, center: [0, 0], low: [0, 0], high: [0, 0] };
} |
Contributor
Author
|
Or perhaps the return type of |
Contributor
|
Sorry it bit you in production. Yes the |
xavi-
force-pushed
the
avoid-null-modelExtents
branch
from
July 3, 2025 00:57
4b3382a to
b7470f3
Compare
xavi-
force-pushed
the
avoid-null-modelExtents
branch
from
July 3, 2025 00:58
b7470f3 to
d944aad
Compare
Contributor
Author
|
Updated PR. Also updated method to explicitly return |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently
makerjs.measure.modelExtents({ models: {} })returnsundefinedwhich makes code prone to NPE'sThis PR updates
modelExtentsto instead return an emptyIMeasureWithCenterobject:{ height: 0, width: 0, center: null, low: null, high: null }