-
Notifications
You must be signed in to change notification settings - Fork 433
Cleanup Fabric OneLake commands #2120
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
alzimmermsft
wants to merge
1
commit into
microsoft:main
Choose a base branch
from
alzimmermsft:MarkToolsAsLocalRequired
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+312
−914
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -376,12 +376,12 @@ This error indicates that the access token doesn't have sufficient permissions t | |
|
|
||
| ### Service Principal Returns 403 for OneLake Operations in VS Code | ||
|
|
||
| When using Azure MCP Server inside VS Code with a Service Principal authenticated via Azure CLI (`az login --service-principal`), OneLake DFS operations (such as `directory_create`, `upload_file`) may return `403 Forbidden`, even though the Service Principal has the correct permissions (e.g., Workspace Admin in Microsoft Fabric). | ||
| When using Azure MCP Server inside VS Code with a Service Principal authenticated via Azure CLI (`az login --service-principal`), OneLake DFS operations (such as `directory_create`, `upload-file`) may return `403 Forbidden`, even though the Service Principal has the correct permissions (e.g., Workspace Admin in Microsoft Fabric). | ||
|
|
||
| #### Symptoms | ||
|
|
||
| - OneLake **blob** operations (e.g., `file_list` without a path) may succeed with `200 OK` | ||
| - OneLake **DFS** operations (e.g., `directory_create`, `upload_file`) fail with `403 Forbidden` | ||
| - OneLake **DFS** operations (e.g., `directory_create`, `upload-file`) fail with `403 Forbidden` | ||
|
||
| - The same Service Principal works correctly when used from Python scripts or other tools outside VS Code | ||
| - Fabric REST API operations (e.g., `item_create`) may also fail with `401 Unauthorized` | ||
|
|
||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
48 changes: 48 additions & 0 deletions
48
tools/Fabric.Mcp.Tools.OneLake/src/Commands/BaseItemCommand.cs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,48 @@ | ||
| // Copyright (c) Microsoft Corporation. | ||
| // Licensed under the MIT License. | ||
|
|
||
| using System.Diagnostics.CodeAnalysis; | ||
| using Azure.Mcp.Core.Commands; | ||
| using Azure.Mcp.Core.Extensions; | ||
| using Fabric.Mcp.Tools.OneLake.Options; | ||
| using Microsoft.Mcp.Core.Extensions; | ||
| using Microsoft.Mcp.Core.Models.Option; | ||
|
|
||
| namespace Fabric.Mcp.Tools.OneLake.Commands; | ||
|
|
||
| public abstract class BaseItemCommand< | ||
| [DynamicallyAccessedMembers(TrimAnnotations.CommandAnnotations)] TOptions> | ||
| : BaseWorkspaceCommand<TOptions> where TOptions : BaseItemOptions, new() | ||
| { | ||
| protected BaseItemCommand() | ||
| { | ||
| } | ||
|
|
||
| protected override void RegisterOptions(Command command) | ||
| { | ||
| base.RegisterOptions(command); | ||
| command.Options.Add(FabricOptionDefinitions.ItemId.AsOptional()); | ||
| command.Options.Add(FabricOptionDefinitions.Item.AsOptional()); | ||
| command.Validators.Add(result => | ||
| { | ||
| var itemId = result.GetValueOrDefault<string>(FabricOptionDefinitions.ItemId.Name); | ||
| var item = result.GetValueOrDefault<string>(FabricOptionDefinitions.Item.Name); | ||
|
|
||
| if (string.IsNullOrWhiteSpace(item) && string.IsNullOrWhiteSpace(itemId)) | ||
| { | ||
| result.AddError("Item identifier is required. Provide --item or --item-id."); | ||
| } | ||
| }); | ||
| } | ||
|
|
||
| protected override TOptions BindOptions(ParseResult parseResult) | ||
| { | ||
| var options = base.BindOptions(parseResult); | ||
| var itemId = parseResult.GetValueOrDefault<string>(FabricOptionDefinitions.ItemId.Name); | ||
| var item = parseResult.GetValueOrDefault<string>(FabricOptionDefinitions.Item.Name); | ||
| options.ItemId = !string.IsNullOrWhiteSpace(itemId) | ||
| ? itemId! | ||
| : item ?? string.Empty; | ||
| return options; | ||
| } | ||
| } |
48 changes: 48 additions & 0 deletions
48
tools/Fabric.Mcp.Tools.OneLake/src/Commands/BaseWorkspaceCommand.cs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,48 @@ | ||
| // Copyright (c) Microsoft Corporation. | ||
| // Licensed under the MIT License. | ||
|
|
||
| using System.Diagnostics.CodeAnalysis; | ||
| using Azure.Mcp.Core.Commands; | ||
| using Azure.Mcp.Core.Extensions; | ||
| using Fabric.Mcp.Tools.OneLake.Options; | ||
| using Microsoft.Mcp.Core.Extensions; | ||
| using Microsoft.Mcp.Core.Models.Option; | ||
|
|
||
| namespace Fabric.Mcp.Tools.OneLake.Commands; | ||
|
|
||
| public abstract class BaseWorkspaceCommand< | ||
| [DynamicallyAccessedMembers(TrimAnnotations.CommandAnnotations)] TOptions> | ||
| : GlobalCommand<TOptions> where TOptions : BaseWorkspaceOptions, new() | ||
| { | ||
| protected BaseWorkspaceCommand() | ||
| { | ||
| } | ||
|
|
||
| protected override void RegisterOptions(Command command) | ||
| { | ||
| base.RegisterOptions(command); | ||
| command.Options.Add(FabricOptionDefinitions.WorkspaceId.AsOptional()); | ||
| command.Options.Add(FabricOptionDefinitions.Workspace.AsOptional()); | ||
| command.Validators.Add(result => | ||
| { | ||
| var workspaceId = result.GetValueOrDefault<string>(FabricOptionDefinitions.WorkspaceId.Name); | ||
| var workspace = result.GetValueOrDefault<string>(FabricOptionDefinitions.Workspace.Name); | ||
|
|
||
| if (string.IsNullOrWhiteSpace(workspaceId) && string.IsNullOrWhiteSpace(workspace)) | ||
| { | ||
| result.AddError("Workspace identifier is required. Provide --workspace or --workspace-id."); | ||
| } | ||
| }); | ||
| } | ||
|
|
||
| protected override TOptions BindOptions(ParseResult parseResult) | ||
| { | ||
| var options = base.BindOptions(parseResult); | ||
| var workspaceId = parseResult.GetValueOrDefault<string>(FabricOptionDefinitions.WorkspaceId.Name); | ||
| var workspaceName = parseResult.GetValueOrDefault<string>(FabricOptionDefinitions.Workspace.Name); | ||
| options.WorkspaceId = !string.IsNullOrWhiteSpace(workspaceId) | ||
| ? workspaceId! | ||
| : workspaceName ?? string.Empty; | ||
| return options; | ||
| } | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The troubleshooting examples mix old underscore-style command names (
directory_create) with the new hyphenated naming (upload-file). Update the remaining OneLake examples to the new tool/command names (and include the correctonelake_prefix if that’s what callers use) so readers can reliably copy/paste working commands.