refactor: normalize ShowAddButton to IsAddButtonVisible#296
Conversation
codemonkeychris
left a comment
There was a problem hiding this comment.
I think we should align with the WinUI names, IsXXX
241c120 to
b9b7452
Compare
|
@codemonkeychris Addressed — updated to align with WinUI's
Force-pushed with the narrower scope. |
|
Thanks for the direction, Chris. Agreed on For the remaining adjective modifiers ( The adjective forms are sugar over the The one case that doesn't map cleanly is Should we do (1) or (2)?
|
Please look at the equivalent in WinUI and follow the pattern to align. |
|
@codemonkeychris Addressed your feedback — all boolean modifiers now use exact WinUI property names (IsEnabled, IsReadOnly, IsEditable, IsClosable, IsActive, IsVisible, IsTextSelectionEnabled, IsDisabledFocusable, IsLightDismissEnabled, IsAddTabButtonVisible). Old names kept as [Obsolete] shims. Ready for re-review when you get a chance. |
Rename ShowAddButton() -> IsAddButtonVisible() to align with WinUI's Is* naming convention for boolean properties. Keep IsTabStop() as-is (already matches WinUI naming). Old ShowAddButton kept as [Obsolete] shim for backward compat. Fixes #268 Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Rename all boolean-style fluent modifiers to align with WinUI property names per reviewer feedback: - Visible -> IsVisible - Disabled -> IsEnabled (inverted) - Selectable -> IsTextSelectionEnabled - ReadOnly -> IsReadOnly (TextField, RatingControl) - Editable -> IsEditable - Closable -> IsClosable - Active -> IsActive - DisabledFocusable -> IsDisabledFocusable - LightDismiss -> IsLightDismissEnabled - IsAddButtonVisible/ShowAddButton -> IsAddTabButtonVisible Old names kept as [Obsolete] shims. All first-party code migrated. API surface files updated. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
f0c4558 to
a54e2ef
Compare
#342) Migrates the remaining doc-pipeline templates, doc apps, and compiled guide pages to the WinUI-aligned boolean modifier names introduced in #296 / #268: .Visible -> .IsVisible .Disabled(x) -> .IsEnabled(!x) (inverted) .Selectable -> .IsTextSelectionEnabled .ReadOnly -> .IsReadOnly .Editable -> .IsEditable .Closable -> .IsClosable .Active -> .IsActive .DisabledFocusable -> .IsDisabledFocusable .LightDismiss -> .IsLightDismissEnabled The original PR migrated first-party code, samples, and a handful of doc apps. This sweep covers the rest: 8 remaining doc apps, 8 templates, and the 10 compiled guide pages that reference them. Compiled output regenerated with `mur docs compile` (recipes pages patched in place to preserve their inlined snippets). Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Rename
ShowAddButton()→IsAddButtonVisible()to align with WinUI'sIs*naming convention for boolean properties (Control.IsTabStop,TabView.IsAddTabButtonVisible, etc.).IsTabStop— kept as-is (already matches WinUI naming per review feedback)ShowAddButton→IsAddButtonVisible(imperative verb →Is*boolean)ShowAddButtonkept as[Obsolete]shim for backward compatibilityreactor.api.txtupdated in both locationsFixes #268