Skip to content

fix(cli): correct scaffolder project path and drop stale WindowsSdkPackageVersion #146

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sundaramramaswamy merged 2 commits into from
May 5, 2026
Merged

fix(cli): correct scaffolder project path and drop stale WindowsSdkPackageVersion #146

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3293ba8
fix(cli): correct Reactor project path in scaffolding
sundaramramaswamy May 4, 2026
3084dd0
fix(cli): drop stale WindowsSdkPackageVersion from scaffolder
sundaramramaswamy May 4, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -158,7 +158,7 @@ Or create a `.csproj` manually:
</PropertyGroup>
<ItemGroup>
<PackageReference Include="Microsoft.WindowsAppSDK" Version="2.0.1" />
<ProjectReference Include="..\Reactor\Reactor.csproj" />
<ProjectReference Include="..\src\Reactor\Reactor.csproj" />
</ItemGroup>
</Project>
```
Expand Down
7 changes: 3 additions & 4 deletions src/Reactor.Cli/Program.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -137,7 +137,7 @@ int CreateProject(string name)
Console.WriteLine();
Console.WriteLine("NOTE: The generated .sln assumes this project is a sibling of the Reactor directory:");
Console.WriteLine($" parent/");
Console.WriteLine($" Reactor/Reactor.csproj");
Console.WriteLine($" src/Reactor/Reactor.csproj");
Console.WriteLine($" {name}/{name}.csproj");
Console.WriteLine();
Console.WriteLine("To build and run:");
Expand Down Expand Up @@ -193,13 +193,12 @@ string GenerateCsproj() =>
<Nullable>enable</Nullable>
<UseWinUI>true</UseWinUI>
<WindowsPackageType>None</WindowsPackageType>
<WindowsSdkPackageVersion>10.0.22621.52</WindowsSdkPackageVersion>
</PropertyGroup>
<ItemGroup>
<PackageReference Include="Microsoft.WindowsAppSDK" Version="2.0.1" />
</ItemGroup>
<ItemGroup>
<ProjectReference Include="..\Reactor\Reactor.csproj" />
<ProjectReference Include="..\src\Reactor\Reactor.csproj" />
</ItemGroup>
</Project>
""";
Expand All @@ -225,7 +224,7 @@ string GenerateSln(string name, string appGuid, string patchGuid)
"MinimumVisualStudioVersion = 10.0.40219.1",
$"Project(\"{csharpGuid}\") = \"{name}\", \"{name}.csproj\", \"{ag}\"",
"EndProject",
$"Project(\"{csharpGuid}\") = \"Reactor\", \"..\\Reactor\\Reactor.csproj\", \"{pg}\"",
$"Project(\"{csharpGuid}\") = \"Reactor\", \"..\\src\\Reactor\\Reactor.csproj\", \"{pg}\"",
"EndProject",
"Global",
$"{t1}GlobalSection(SolutionConfigurationPlatforms) = preSolution",
Expand Down
Loading