Skip to content

spec(047): close V1-protocol descriptor regressions (default stays V1 OFF) #443

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
codemonkeychris merged 10 commits into from
May 29, 2026
Merged

spec(047): close V1-protocol descriptor regressions (default stays V1 OFF) #443

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
09bcdbe
spec(047): Engine A1 — post-children mount hook for V1 handlers
codemonkeychris May 28, 2026
16e522a
TabItemsHost: in-place reconcile instead of full rebuild on update
codemonkeychris May 28, 2026
d4aca90
Spec 047 §14: route NavigationHost through V1 dispatch
codemonkeychris May 28, 2026
b779e59
Spec 047 §14: route GridView through V1 dispatch
codemonkeychris May 28, 2026
15a9517
Close V1 overlay dispatch carves (spec 047 §14 prelude)
codemonkeychris May 28, 2026
1479800
Close V1 TabView dispatch carve via Path B delegate (spec 047 §14 pre…
codemonkeychris May 29, 2026
2c966e2
Close V1 Button ContentElement gap via Path B delegate (spec 047 §14 …
codemonkeychris May 29, 2026
3a19724
Fix V1 panel keyed-reconcile gap via Path B delegate handlers
codemonkeychris May 29, 2026
305aea3
Fix V1 Lazy*Stack ScrollViewer-wrapper gap via derived-type delegate
codemonkeychris May 29, 2026
c8c298d
Fix 3 V1-ON regressions via Path B delegate handlers
codemonkeychris May 29, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
42 changes: 21 additions & 21 deletions src/Reactor/Core/Reconciler.Mount.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -301,7 +301,7 @@ private WinUI.RichTextBlock MountRichTextBlock(RichTextBlockElement richText)
return rtb;
}

private WinUI.Button MountButton(ButtonElement btn, Action requestRerender)
internal WinUI.Button MountButton(ButtonElement btn, Action requestRerender)
{
var rented = _pool.TryRent(typeof(WinUI.Button));
var button = rented as WinUI.Button ?? new WinUI.Button();
Expand Down Expand Up @@ -675,7 +675,7 @@ private WinUI.AutoSuggestBox MountAutoSuggestBox(AutoSuggestBoxElement asb)
return box;
}

private WinUI.CheckBox MountCheckBox(CheckBoxElement cb)
internal WinUI.CheckBox MountCheckBox(CheckBoxElement cb)
{
var checkBox = new WinUI.CheckBox { Content = cb.Label };
if (cb.IsThreeState)
Expand Down Expand Up @@ -1116,7 +1116,7 @@ private WinUI.RichEditBox MountRichEditBox(RichEditBoxElement reb)
return box;
}

private WinUI.VariableSizedWrapGrid MountWrapGrid(WrapGridElement wg, Action requestRerender)
internal WinUI.VariableSizedWrapGrid MountWrapGrid(WrapGridElement wg, Action requestRerender)
{
var grid = new WinUI.VariableSizedWrapGrid { Orientation = wg.Orientation };
if (wg.MaximumRowsOrColumns >= 0) grid.MaximumRowsOrColumns = wg.MaximumRowsOrColumns;
Expand All @@ -1140,7 +1140,7 @@ private WinUI.VariableSizedWrapGrid MountWrapGrid(WrapGridElement wg, Action req
return grid;
}

private WinUI.StackPanel MountStack(StackElement stack, Action requestRerender)
internal WinUI.StackPanel MountStack(StackElement stack, Action requestRerender)
{
var panel = _pool.TryRent(typeof(WinUI.StackPanel)) as WinUI.StackPanel ?? new WinUI.StackPanel();
panel.Orientation = stack.Orientation;
Expand All @@ -1160,7 +1160,7 @@ private WinUI.StackPanel MountStack(StackElement stack, Action requestRerender)
return panel;
}

private WinUI.Grid MountGrid(GridElement grid, Action requestRerender)
internal WinUI.Grid MountGrid(GridElement grid, Action requestRerender)
{
var g = _pool.TryRent(typeof(WinUI.Grid)) as WinUI.Grid ?? new WinUI.Grid();
g.RowSpacing = grid.RowSpacing;
Expand Down Expand Up @@ -1268,7 +1268,7 @@ private WinUI.Border MountBorder(BorderElement border, Action requestRerender)
return bdr;
}

private WinUI.Expander MountExpander(ExpanderElement exp, Action requestRerender)
internal WinUI.Expander MountExpander(ExpanderElement exp, Action requestRerender)
{
var expander = new WinUI.Expander
{
Expand Down Expand Up @@ -1325,7 +1325,7 @@ private WinUI.Viewbox MountViewbox(ViewboxElement vb, Action requestRerender)
return viewbox;
}

private WinUI.Canvas MountCanvas(CanvasElement cvs, Action requestRerender)
internal WinUI.Canvas MountCanvas(CanvasElement cvs, Action requestRerender)
{
var canvas = _pool.TryRent(typeof(WinUI.Canvas)) as WinUI.Canvas ?? new WinUI.Canvas();
if (cvs.Width.HasValue) canvas.Width = cvs.Width.Value;
Expand All @@ -1345,7 +1345,7 @@ private WinUI.Canvas MountCanvas(CanvasElement cvs, Action requestRerender)
return canvas;
}

private Layout.FlexPanel MountFlex(FlexElement flex, Action requestRerender)
internal Layout.FlexPanel MountFlex(FlexElement flex, Action requestRerender)
{
var panel = _pool.TryRent(typeof(Layout.FlexPanel)) as Layout.FlexPanel ?? new Layout.FlexPanel();
panel.Direction = flex.Direction;
Expand All @@ -1369,7 +1369,7 @@ private Layout.FlexPanel MountFlex(FlexElement flex, Action requestRerender)
return panel;
}

private WinUI.Grid MountNavigationHost(NavigationHostElement element, Action requestRerender)
internal WinUI.Grid MountNavigationHost(NavigationHostElement element, Action requestRerender)
{
var grid = new WinUI.Grid();
var handle = (Navigation.INavigationHandle)element.NavigationHandle;
Expand Down Expand Up @@ -1507,7 +1507,7 @@ private WinUI.TitleBar MountTitleBar(TitleBarElement tb, Action requestRerender)
return titleBar;
}

private WinUI.TabView MountTabView(TabViewElement tab, Action requestRerender)
internal WinUI.TabView MountTabView(TabViewElement tab, Action requestRerender)
{
var tv = new WinUI.TabView
{
Expand Down Expand Up @@ -1803,7 +1803,7 @@ internal WinUI.ListView MountListView(ListViewElement lv, Action requestRerender
return listView;
}

private WinUI.GridView MountGridView(GridViewElement gv, Action requestRerender)
internal WinUI.GridView MountGridView(GridViewElement gv, Action requestRerender)
{
var gridView = new WinUI.GridView
{
Expand Down Expand Up @@ -1986,7 +1986,7 @@ private WinUI.FlipView MountFlipView(FlipViewElement fv, Action requestRerender)
return flipView;
}

private UIElement MountTemplatedList(TemplatedListElementBase el, Action requestRerender)
internal UIElement MountTemplatedList(TemplatedListElementBase el, Action requestRerender)
{
return el.ControlKind switch
{
Expand Down Expand Up @@ -2295,7 +2295,7 @@ private WinUI.InfoBadge MountInfoBadge(InfoBadgeElement badge)
return ib;
}

private UIElement MountContentDialog(ContentDialogElement cdEl, Action requestRerender)
internal UIElement MountContentDialog(ContentDialogElement cdEl, Action requestRerender)
{
var placeholder = new WinUI.StackPanel { Visibility = Visibility.Collapsed };
SetElementTag(placeholder, cdEl);
Expand Down Expand Up @@ -2350,7 +2350,7 @@ private async void ShowContentDialogCore(ContentDialogElement cdEl, XamlRoot? xa
cdEl.OnClosed?.Invoke(winUiResult);
}

private UIElement? MountFlyout(FlyoutElement flyEl, Action requestRerender)
internal UIElement? MountFlyout(FlyoutElement flyEl, Action requestRerender)
{
var target = Mount(flyEl.Target, requestRerender);
if (target is FrameworkElement targetFe)
Expand Down Expand Up @@ -2411,7 +2411,7 @@ private WinUI.TeachingTip MountTeachingTip(TeachingTipElement ttEl, Action reque
return tip;
}

private WinUI.MenuBar MountMenuBar(MenuBarElement mbEl)
internal WinUI.MenuBar MountMenuBar(MenuBarElement mbEl)
{
var menuBar = new WinUI.MenuBar();
foreach (var menuItem in mbEl.Items)
Expand Down Expand Up @@ -2488,7 +2488,7 @@ private static bool IsDescendantOf(DependencyObject element, DependencyObject an
return false;
}

private WinUI.CommandBar MountCommandBar(CommandBarElement cmdEl, Action requestRerender)
internal WinUI.CommandBar MountCommandBar(CommandBarElement cmdEl, Action requestRerender)
{
var commandBar = new WinUI.CommandBar
{
Expand Down Expand Up @@ -2543,7 +2543,7 @@ private static WinUI.ICommandBarElement CreateAppBarItem(AppBarItemBase item)
}
}

private UIElement? MountMenuFlyout(MenuFlyoutElement mfEl, Action requestRerender)
internal UIElement? MountMenuFlyout(MenuFlyoutElement mfEl, Action requestRerender)
{
var target = Mount(mfEl.Target, requestRerender);
if (target is FrameworkElement targetFe)
Expand Down Expand Up @@ -3177,7 +3177,7 @@ private static Internal.ReactorListState BuildListStateForItemsRepeater(ItemsRep
return state;
}

private UIElement MountLazyStack(LazyStackElementBase lazy, Action requestRerender)
internal UIElement MountLazyStack(LazyStackElementBase lazy, Action requestRerender)
{
var repeater = new WinUI.ItemsRepeater();

Expand Down Expand Up @@ -3462,7 +3462,7 @@ private WinShapes.Path MountPath(PathElement pa)

// ── RelativePanel ───────────────────────────────────────────────────

private WinUI.RelativePanel MountRelativePanel(RelativePanelElement rp, Action requestRerender)
internal WinUI.RelativePanel MountRelativePanel(RelativePanelElement rp, Action requestRerender)
{
var panel = new WinUI.RelativePanel();
var nameMap = new Dictionary<string, UIElement>();
Expand Down Expand Up @@ -3680,7 +3680,7 @@ private WinUI.AnnotatedScrollBar MountAnnotatedScrollBar(AnnotatedScrollBarEleme

// ── Popup ───────────────────────────────────────────────────────────

private UIElement MountPopup(PopupElement popup, Action requestRerender)
internal UIElement MountPopup(PopupElement popup, Action requestRerender)
{
// Popup is not a UIElement child, so we wrap it in a StackPanel
var wrapper = new WinUI.StackPanel();
Expand Down Expand Up @@ -3719,7 +3719,7 @@ private WinUI.RefreshContainer MountRefreshContainer(RefreshContainerElement rc,

// ── CommandBarFlyout ────────────────────────────────────────────────

private UIElement? MountCommandBarFlyout(CommandBarFlyoutElement cbf, Action requestRerender)
internal UIElement? MountCommandBarFlyout(CommandBarFlyoutElement cbf, Action requestRerender)
{
var target = Mount(cbf.Target, requestRerender);
if (target is FrameworkElement targetFe)
Expand Down
Loading
Loading