Fix static CRT compilation #642
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use CMake 3.28 for compatibility with MSVC 17.10 LTS
Alovchin91
requested review from
JohnMcPMS,
kyelamarthi1,
msftrubengu,
ranm-msft and
sachinkumar-2106
as code owners
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, static CRT compilation doesn't work, because
/NODEFAULTLIB:MSVCRT(D)simply leaves a number of unresolved external references behind.#628 has upgraded CMake to version 3.29 which enables the use of
CMAKE_MSVC_RUNTIME_LIBRARY. That makes static CRT use much easier, so we can take advantage of this.I've also downgraded CMake slightly to version 3.28 so that it can be compiled with the version shipped with Visual C++ Build Tools 17.10 LTS.
/cc @msftrubengu