Rust: Enable server client test on nix #4936
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4936 +/- ##
==========================================
- Coverage 87.42% 87.02% -0.41%
==========================================
Files 56 56
Lines 17726 17723 -3
==========================================
- Hits 15497 15423 -74
- Misses 2229 2300 +71 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
nibanks
reviewed
Mar 21, 2025
src/rs/server_client_test.rs
Outdated
| pub fn get_test_cred() -> Credential { | ||
| use crate::CertificateFile; | ||
| let root_dir = std::env::current_dir().unwrap(); | ||
| let cert_dir = root_dir.join("submodules/openssl/test/certs"); |
There was a problem hiding this comment.
I don't care for depending on a specific submodule file.
- I want to make sure we can support openssl3 in the near future.
- I am thinking about moving away from submodules and dynamically resolving these dependencies (probably via cmake), and they might be in different directories.
There was a problem hiding this comment.
Changed to use openssl cli to generate test certs in temp dir.
nibanks
approved these changes
Mar 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Enable server client test on linux an macos.
Using test certs in the openssl submodule.
Removed code that sets the handle context to null after the handle close. It causes access violation in some cases, and handle after close should not be accessed anymore.
Testing
NA
Documentation
NA