Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid reuse of a global buffer between test cases #4937

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

guhetier
Copy link
Contributor

Description

QuicTestStreamMultiReceive was using a global buffer as a send buffer, shared between test cases.
Test cases would modify the buffer, but also assume it was zeroed.

Testing

CI

Documentation

N/A

Copy link

codecov bot commented Mar 22, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.24%. Comparing base (9be1d72) to head (2727867).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4937      +/-   ##
==========================================
- Coverage   87.45%   86.24%   -1.21%     
==========================================
  Files          56       56              
  Lines       17723    17723              
==========================================
- Hits        15499    15286     -213     
- Misses       2224     2437     +213     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@nibanks nibanks added the Bug: Test/Tool Code bug in the test or tool specific code. label Mar 24, 2025
@guhetier guhetier marked this pull request as ready for review March 25, 2025 21:03
@guhetier guhetier requested a review from a team as a code owner March 25, 2025 21:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug: Test/Tool Code bug in the test or tool specific code.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants