Skip to content

Conversation

@mtfriesen
Copy link
Contributor

Description

Describe the purpose of and changes within this Pull Request.

The QuicTestNthPacketDrop test hit

DataTest.cpp(3006): error: RecvContext.ServerStreamShutdown.WaitTimeout(2000) not true

but after looking at the logs, it was making fairly steady progress over two seconds, as far as I can tell. I suspect we just randomly tripped across the existing 2 second limit due to bad luck, so doubled the limit, which is not integral to the test itself.

Resolves #5676

Testing

Do any existing tests cover this change? Are new tests needed?

Builds locally.

Documentation

Is there any documentation impact for this change?

N/A.

@mtfriesen mtfriesen requested a review from a team as a code owner January 6, 2026 21:35
@mtfriesen mtfriesen enabled auto-merge (squash) January 6, 2026 21:35
@mtfriesen mtfriesen changed the title double wait time in drop test Double wait time in flaky drop test Jan 6, 2026
@codecov
Copy link

codecov bot commented Jan 6, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 84.88%. Comparing base (9117f56) to head (5d0d8ea).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5704      +/-   ##
==========================================
- Coverage   86.20%   84.88%   -1.32%     
==========================================
  Files          60       60              
  Lines       18663    18663              
==========================================
- Hits        16089    15843     -246     
- Misses       2574     2820     +246     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@mtfriesen mtfriesen merged commit 1506ae6 into main Jan 7, 2026
523 checks passed
@mtfriesen mtfriesen deleted the mtfriesen/flaky_drop_test branch January 7, 2026 18:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[CI - FAILURE]: BVT-Debug-windows-windows-2025-x64-schannel-UseXdp-UseQtip-SanitizeAddress / Misc.NthPacketDrop_1 (msquictest.exe)

4 participants