Double wait time in flaky drop test #5704
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Describe the purpose of and changes within this Pull Request.
The QuicTestNthPacketDrop test hit
DataTest.cpp(3006): error: RecvContext.ServerStreamShutdown.WaitTimeout(2000) not truebut after looking at the logs, it was making fairly steady progress over two seconds, as far as I can tell. I suspect we just randomly tripped across the existing 2 second limit due to bad luck, so doubled the limit, which is not integral to the test itself.
Resolves #5676
Testing
Do any existing tests cover this change? Are new tests needed?
Builds locally.
Documentation
Is there any documentation impact for this change?
N/A.