Skip to content

Fix ASAN leaks in casted_clog_bytearray with stdout logging #5800

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Copilot wants to merge 6 commits into
base: main
Choose a base branch
from
+9 −4
Open

Fix ASAN leaks in casted_clog_bytearray with stdout logging #5800

Show file tree
Hide file tree
Changes from 5 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
4cb7822
Initial plan
Copilot Feb 18, 2026
b11b81b
Fix ASAN leaks in clog_stdout by passing head as double pointer
Copilot Feb 18, 2026
13d45f8
Fix ASAN leaks in casted_clog_bytearray with stdout logging
Copilot Feb 18, 2026
684e327
Remove accidentally committed CodeQL build artifacts and add to .giti…
Copilot Feb 18, 2026
db56554
Revert .gitignore change - keep PR scoped to quic_trace.h and quic_tr…
Copilot Feb 19, 2026
031ef66
Add comment explaining &__head double-pointer pattern in clog macro
Copilot Feb 20, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion src/generated/stdout/quic_trace.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,8 +65,9 @@ char * casted_clog_bytearray(const uint8_t * const data,
}


void clog_stdout(struct clog_param * head, const char * const format, ...)
void clog_stdout(struct clog_param ** head_ptr, const char * const format, ...)
{
struct clog_param * head = *head_ptr;
Copy link
Collaborator

@guhetier guhetier Feb 19, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Isn't this generated code? Is it going to survive the next generation?

Copy link
Collaborator

@guhetier guhetier Feb 19, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(looking more, the file does seem generated, which raises questions about what it is doing in a "generated" folder).

Copy link
Contributor

@mtfriesen mtfriesen Feb 20, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this the "CLOG should generate at build time" problem?

Copy link
Contributor Author

Copilot AI Feb 20, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The file is in a generated folder but it's not auto-generated by any build tooling — it's hand-maintained code that was placed there historically. There's no generation step that would overwrite these changes.

Copy link
Contributor

@mtfriesen mtfriesen Feb 20, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why did you answer me and not @guhetier?

Copy link
Collaborator

@guhetier guhetier Feb 23, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this the "CLOG should generate at build time" problem?

Not really, more that we seem to have a mix of generated and non-generated files in the same folder. Not a big issue, just slightly confusing. Maybe we can fix this one day to scratch the itch, but not worth a bug imo.

char * reformat;

if (strstr(format, "%!") == 0) {
Expand Down
6 changes: 3 additions & 3 deletions src/inc/quic_trace.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -165,10 +165,10 @@ extern
"C"
#endif
void //__attribute__((no_instrument_function, format(printf, 2, 3)))
clog_stdout(struct clog_param * head, const char * format, ...);
clog_stdout(struct clog_param ** head, const char * format, ...);
#else
QUIC_INLINE void //__attribute__((no_instrument_function, format(printf, 2, 3)))
clog_stdout(struct clog_param * head, const char * format, ...)
clog_stdout(struct clog_param ** head, const char * format, ...)
{
UNREFERENCED_PARAMETER(head);
UNREFERENCED_PARAMETER(format);
Expand All @@ -178,7 +178,7 @@ clog_stdout(struct clog_param * head, const char * format, ...)
#define clog(Fmt, ...) \
do { \
struct clog_param * __head = 0; \
clog_stdout(__head, (Fmt), ##__VA_ARGS__); \
clog_stdout(&__head, (Fmt), ##__VA_ARGS__); \
} while (0)

#endif
Expand Down
Loading