Fix memory leak in ServerSendIp error paths#5802
Open
MarkedMuichiro wants to merge 1 commit intomicrosoft:mainfrom
Open
Fix memory leak in ServerSendIp error paths#5802MarkedMuichiro wants to merge 1 commit intomicrosoft:mainfrom
MarkedMuichiro wants to merge 1 commit intomicrosoft:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes #5255.
Adds missing CXPLAT_FREE(SendBufferRaw, QUIC_POOL_TOOL) calls in early
error-return paths in ServerSendIp() to prevent a potential memory leak
when StreamOpen or StreamStart fails.
This change only affects test tooling code in:
src/tools/ip/server/quicipserver.cpp
Testing
No new tests added.
The affected code is part of test tooling, and the failure paths
require StreamOpen or StreamStart to fail, which would require
fault injection or specific runtime conditions to exercise reliably.
Built successfully locally on Linux (GitHub Codespaces).
Documentation
None.