Skip to content

Shift Linux OpenSSL CI Coverage to Ubuntu 26.04 #6155

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Santhosha-bk wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Shift Linux OpenSSL CI Coverage to Ubuntu 26.04 #6155

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
2076769
Updating ubuntu-26.04 support to linux CI flow
Santhosha-bk Jul 16, 2026
6d327cf
Removed dockerfile changes
Santhosha-bk Jul 23, 2026
6c229f3
Fixing build issues
Santhosha-bk Jul 23, 2026
b55b124
Fixing Test failures
Santhosha-bk Jul 24, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .github/workflows/build-reuse-unix.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,6 +36,7 @@ on:
# options:
# - ubuntu-22.04
# - ubuntu-24.04
# - ubuntu-26.04
# - macos-15
arch:
required: false
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/build.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -122,7 +122,7 @@ jobs:
matrix:
config: ['Debug', 'Release']
plat: [linux, android]
os: ['ubuntu-22.04', 'ubuntu-24.04']
os: ['ubuntu-22.04', 'ubuntu-24.04', 'ubuntu-26.04']
arch: [x86, x64]
tls: [quictls, openssl]
systemcrypto: ['', '-UseSystemOpenSSLCrypto']
Expand Down
15 changes: 15 additions & 0 deletions .github/workflows/test.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -108,8 +108,16 @@ jobs:
{ config: "Debug", plat: "linux", os: "ubuntu-24.04", arch: "x64", tls: "quictls", systemcrypto: "-UseSystemOpenSSLCrypto", build: "-Test", iouring: "-UseIoUring" },
{ config: "Debug", plat: "linux", os: "ubuntu-24.04", arch: "x64", tls: "quictls", systemcrypto: "-UseSystemOpenSSLCrypto", build: "-Test", sanitize: "-SanitizeAddress", iouring: "-UseIoUring" },
{ config: "Release", plat: "linux", os: "ubuntu-24.04", arch: "x64", tls: "quictls", systemcrypto: "-UseSystemOpenSSLCrypto", build: "-Test", iouring: "-UseIoUring" },
{ config: "Debug", plat: "linux", os: "ubuntu-26.04", arch: "x64", tls: "quictls", systemcrypto: "-UseSystemOpenSSLCrypto", sanitize: "-SanitizeAddress", build: "-Test" },
{ config: "Release", plat: "linux", os: "ubuntu-26.04", arch: "x64", tls: "quictls", systemcrypto: "-UseSystemOpenSSLCrypto", build: "-Test" },
{ config: "Debug", plat: "linux", os: "ubuntu-22.04", arch: "x64", tls: "openssl", sanitize: "-SanitizeAddress", build: "-Test" },
{ config: "Debug", plat: "linux", os: "ubuntu-24.04", arch: "x64", tls: "openssl", sanitize: "-SanitizeAddress", build: "-Test" },
{ config: "Debug", plat: "linux", os: "ubuntu-26.04", arch: "x64", tls: "openssl", sanitize: "-SanitizeAddress", build: "-Test" },
{ config: "Debug", plat: "linux", os: "ubuntu-26.04", arch: "x64", tls: "openssl", systemcrypto: "-UseSystemOpenSSLCrypto", sanitize: "-SanitizeAddress", build: "-Test" },
{ config: "Release", plat: "linux", os: "ubuntu-26.04", arch: "x64", tls: "openssl", systemcrypto: "-UseSystemOpenSSLCrypto", build: "-Test" },
{ config: "Debug", plat: "linux", os: "ubuntu-26.04", arch: "x64", tls: "openssl", systemcrypto: "-UseSystemOpenSSLCrypto", build: "-Test", iouring: "-UseIoUring" },
{ config: "Debug", plat: "linux", os: "ubuntu-26.04", arch: "x64", tls: "openssl", systemcrypto: "-UseSystemOpenSSLCrypto", sanitize: "-SanitizeAddress", build: "-Test", iouring: "-UseIoUring" },
{ config: "Release", plat: "linux", os: "ubuntu-26.04", arch: "x64", tls: "openssl", systemcrypto: "-UseSystemOpenSSLCrypto", build: "-Test", iouring: "-UseIoUring" },
]
uses: ./.github/workflows/build-reuse-unix.yml
with:
Expand Down Expand Up @@ -139,7 +147,14 @@ jobs:
{ config: "Release", plat: "linux", os: "ubuntu-24.04", arch: "x64", tls: "quictls", systemcrypto: "-UseSystemOpenSSLCrypto", build: "-Test" },
{ config: "Debug", plat: "linux", os: "ubuntu-24.04", arch: "x64", tls: "quictls", systemcrypto: "-UseSystemOpenSSLCrypto", build: "-Test", iouring: "-UseIoUring" },
{ config: "Release", plat: "linux", os: "ubuntu-24.04", arch: "x64", tls: "quictls", systemcrypto: "-UseSystemOpenSSLCrypto", build: "-Test", iouring: "-UseIoUring" },
{ config: "Debug", plat: "linux", os: "ubuntu-26.04", arch: "x64", tls: "quictls", systemcrypto: "-UseSystemOpenSSLCrypto", sanitize: "-SanitizeAddress", build: "-Test" },
{ config: "Release", plat: "linux", os: "ubuntu-26.04", arch: "x64", tls: "quictls", systemcrypto: "-UseSystemOpenSSLCrypto", build: "-Test" },
{ config: "Debug", plat: "linux", os: "ubuntu-22.04", arch: "x64", tls: "openssl", sanitize: "-SanitizeAddress", build: "-Test" },
{ config: "Debug", plat: "linux", os: "ubuntu-26.04", arch: "x64", tls: "openssl", sanitize: "-SanitizeAddress", build: "-Test" },
{ config: "Debug", plat: "linux", os: "ubuntu-26.04", arch: "x64", tls: "openssl", systemcrypto: "-UseSystemOpenSSLCrypto", sanitize: "-SanitizeAddress", build: "-Test" },
{ config: "Release", plat: "linux", os: "ubuntu-26.04", arch: "x64", tls: "openssl", systemcrypto: "-UseSystemOpenSSLCrypto", build: "-Test" },
{ config: "Debug", plat: "linux", os: "ubuntu-26.04", arch: "x64", tls: "openssl", systemcrypto: "-UseSystemOpenSSLCrypto", build: "-Test", iouring: "-UseIoUring" },
{ config: "Release", plat: "linux", os: "ubuntu-26.04", arch: "x64", tls: "openssl", systemcrypto: "-UseSystemOpenSSLCrypto", build: "-Test", iouring: "-UseIoUring" },
{ config: "Debug", plat: "windows", os: "windows-2022", arch: "x64", tls: "schannel", sanitize: "-SanitizeAddress", build: "-Test", log: "Full.Verbose" },
{ config: "Debug", plat: "windows", os: "windows-2022", arch: "x64", tls: "schannel", xdp: "xdp-v1.1", sanitize: "-SanitizeAddress", build: "-Test" },
{ config: "Debug", plat: "windows", os: "windows-2022", arch: "x64", tls: "schannel", xdp: "xdp-v1.1", qtip: "-UseQtip", sanitize: "-SanitizeAddress", build: "-Test" },
Expand Down
24 changes: 10 additions & 14 deletions src/platform/tls_openssl.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2868,18 +2868,6 @@ static int SplitAddRecord(RECORD_ENTRY *Entry, size_t *Consumed)
//
message_size = htonl(message_size) & 0x00ffffff;

//
//make sure our message type is valid
//
if (message_type > SSL3_MT_FINISHED) {
//
// This is not a real handshake record
//
CXPLAT_FREE(Entry, QUIC_POOL_TLS_RECORD_ENTRY);
return -1;
}


//
// Stop processing if this is a handshake finished record
//
Expand Down Expand Up @@ -3167,10 +3155,18 @@ CxPlatTlsProcessData(
*BufferLength, &Consumed);
if (MRet == 0) {
//
// There was an allocation failure
// Indicate we consumed nothing
// There was a record processing failure.
// Indicate we consumed nothing and stop the handshake path.
//
QuicTraceEvent(
TlsError,
"[ tls][%p] ERROR, %s.",
TlsContext->Connection,
"ProcessNewMessage failed");
TlsContext->ResultFlags |= CXPLAT_TLS_RESULT_ERROR;
State->AlertCode = CXPLAT_TLS_ALERT_CODE_INTERNAL_ERROR;
Consumed = 0;
goto Exit;
}
*BufferLength = *BufferLength - (uint32_t)Consumed;
}
Expand Down
1 change: 1 addition & 0 deletions src/test/bin/quic_gtest.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,7 @@

#include <array>
#include <vector>
#include <algorithm>

#if defined(_WIN32) && defined(QUIC_API_ENABLE_PREVIEW_FEATURES)
#define XDP_API_VERSION 3
Expand Down
Loading