Skip to content

Validate VN packet SourceCid #6167

Open
gaurav2699 wants to merge 16 commits into
mainfrom
assert_vn
Open

Validate VN packet SourceCid #6167
gaurav2699 wants to merge 16 commits into
mainfrom
assert_vn

Conversation

@gaurav2699

Copy link
Copy Markdown
Contributor

Description

Resolves a long-standing TODO in QuicConnRecvVerNeg that noted the VN
packet's Source Connection ID should be validated against our current
Destination CID.

Testing

Do any existing tests cover this change? Are new tests needed?

Documentation

Is there any documentation impact for this change?

@gaurav2699
gaurav2699 requested a review from a team as a code owner July 20, 2026 18:21
@codecov

codecov Bot commented Jul 20, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 71.42857% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 85.41%. Comparing base (1739655) to head (4f2d364).

Files with missing lines Patch % Lines
src/core/connection.c 71.42% 2 Missing ⚠️

❌ Your patch check has failed because the patch coverage (71.42%) is below the target coverage (80.00%). You can increase the patch coverage or adjust the target coverage.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6167      +/-   ##
==========================================
- Coverage   85.96%   85.41%   -0.56%     
==========================================
  Files          60       60              
  Lines       18974    18981       +7     
==========================================
- Hits        16311    16212      -99     
- Misses       2663     2769     +106     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

anrossi
anrossi previously approved these changes Jul 21, 2026
@anrossi

anrossi commented Jul 21, 2026

Copy link
Copy Markdown
Collaborator

You could see if updating QuicDrillTestServerVNPacket to test this is feasible

Comment thread src/core/connection.c
Comment thread src/core/connection.c Outdated
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants