Feature-32573 When using AccessTokenCallback, remove validation that requires Password to be empty. #2544
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ord to be empty SQLServerConnection connectInternal() throws exception R_AccessTokenCallbackWithUserPassword. This logic may be too restrictive and may be removed. https://sqlclientdrivers.visualstudio.com/mssql-jdbc/_workitems/edit/32573
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2544 +/- ##
============================================
+ Coverage 51.10% 51.23% +0.12%
- Complexity 3935 3972 +37
============================================
Files 147 147
Lines 33460 33666 +206
Branches 5608 5655 +47
============================================
+ Hits 17101 17248 +147
- Misses 13971 14005 +34
- Partials 2388 2413 +25 ☔ View full report in Codecov by Sentry. |
…WithUserPassword. This logic may be too restrictive and may be removed
lilgreenbird
suggested changes
Nov 27, 2024
Contributor
lilgreenbird
left a comment
lilgreenbird
left a comment
There was a problem hiding this comment.
this should just be closed? #2549 includes this change already
Contributor
Author
|
Changes have already been requested as a part of #2549 , hence closing the PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SQLServerConnection connectInternal() throws exception R_AccessTokenCallbackWithUserPassword. This logic may be too restrictive and may be removed.
https://sqlclientdrivers.visualstudio.com/mssql-jdbc/_workitems/edit/32573