Skip to content

Conversation

@Jeffery-Wasty
Copy link
Contributor

Remove testing that the execution time is below a maximum for CRL. Minimum testing is required, as this tells us if a retry actually happened, but maximum can be affected by factors outside the feature and test and can not be reliably tested.

@Jeffery-Wasty Jeffery-Wasty added this to the 12.9.0 milestone Nov 21, 2024
@Jeffery-Wasty Jeffery-Wasty self-assigned this Nov 21, 2024
@codecov
Copy link

codecov bot commented Nov 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 50.99%. Comparing base (5297987) to head (dbf5c44).
Report is 2 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #2545      +/-   ##
============================================
- Coverage     51.10%   50.99%   -0.12%     
+ Complexity     3935     3917      -18     
============================================
  Files           147      147              
  Lines         33460    33460              
  Branches       5608     5608              
============================================
- Hits          17101    17062      -39     
- Misses        13971    13986      +15     
- Partials       2388     2412      +24     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

@lilgreenbird lilgreenbird changed the title Remove maximum testing from CRL Remove maximum time testing from CRL Nov 22, 2024
@Jeffery-Wasty Jeffery-Wasty merged commit fc0cfab into main Nov 22, 2024
7 of 17 checks passed
@Jeffery-Wasty Jeffery-Wasty deleted the CRL-max branch November 22, 2024 20:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Closed/Merged PRs

Development

Successfully merging this pull request may close these issues.

4 participants