Skip to content

Update logger level to FINE for PerformaceLogger #2836

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
muskan124947 merged 1 commit into from
Nov 11, 2025
+6 −6
Merged

Update logger level to FINE for PerformaceLogger #2836

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions src/main/java/com/microsoft/sqlserver/jdbc/PerformanceLog.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,7 +59,7 @@ public Scope(Logger logger, int connectionId, PerformanceActivity activity) {
public Scope(Logger logger, int connectionId, int statementId, PerformanceActivity activity) {

// Check if logging is enabled
this.enabled = logger.isLoggable(Level.INFO) || (callback != null);
this.enabled = logger.isLoggable(Level.FINE) || (callback != null);

if (enabled) {
this.logger = logger;
Expand Down Expand Up @@ -103,15 +103,15 @@ public void close() {
}

} catch (Exception e) {
logger.info(String.format("Failed to publish performance log: %s", e.getMessage()));
logger.fine(String.format("Failed to publish performance log: %s", e.getMessage()));
}
}

if (logger != null && logger.isLoggable(Level.INFO)) {
if (logger != null && logger.isLoggable(Level.FINE)) {
if (exception != null) {
logger.info(String.format("%s %s, duration: %dms, exception: %s", getTraceId(), activity, duration, exception.getMessage()));
logger.fine(String.format("%s %s, duration: %dms, exception: %s", getTraceId(), activity, duration, exception.getMessage()));
} else {
logger.info(String.format("%s %s, duration: %dms", getTraceId(), activity, duration));
logger.fine(String.format("%s %s, duration: %dms", getTraceId(), activity, duration));
}
}

Expand Down
2 changes: 1 addition & 1 deletion src/test/java/com/microsoft/sqlserver/jdbc/PerformanceLogCallbackTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@ class PerformanceLogCallbackTest extends AbstractTest {
perfLogHandler = new FileHandler("performance.log", true);
perfLogHandler.setFormatter(new SimpleFormatter());
perfLogger.addHandler(perfLogHandler);
perfLogger.setLevel(Level.INFO);
perfLogger.setLevel(Level.FINE);
perfLogger.setUseParentHandlers(false);
} catch (IOException e) {
e.printStackTrace();
Expand Down
Loading