Account for defaults when normalizing properties #2852
+32
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Author
|
@microsoft-github-policy-service agree company="Viakoo Inc" |
Contributor
|
a similar patch was dismissed already: #1959 |
Author
|
@mmimica Thanks for the link to the other issue. If this gets rejected I hope to get some clarity on the decision to not move forward with it at least. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem description
When passing in a Properties object to the SQLServerDriver the supplied properties go through a normalization process. The current normalization (fixupProperties(Properties props)) ignores any default values and only enumerates the explicitly set properties.
Fixes existing GitHub issue
N/A
Fix Description
This fix changes the enumeration when normalizing the properties to also account for any default values.
New Public APIs
N/A