fix: Support IP address validation in certificate SAN #2865
+171
−27
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Author
|
@microsoft-github-policy-service agree company="Chunghwa Telecom" |
Fix SSL certificate validation to check for IP address entries (type 7) in Subject Alternative Name extension, in addition to DNS names (type 2). This allows connections via IP address when the certificate's SAN contains that IP, without requiring the hostNameInCertificate workaround.
tan9
force-pushed
the
fix/ip-address-san-validation
branch
from
7cbdbc7 to
73a5038
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #2529
This PR fixes SSL certificate validation to properly handle IP address entries (type 7) in the Subject Alternative Name (SAN) extension, in addition to DNS names (type 2).
Problem
When connecting to SQL Server using an IP address with SSL encryption enabled, the driver throws an
SSLHandshakeExceptionwith "Failed to validate the server name" even when the certificate's SAN contains that IP address. This is becauseSQLServerCertificateUtils.validateServerNameInCertificate()only checks for DNS name entries (type 2) and ignores IP address entries (type 7).Solution
Updated the certificate validation logic to also check for IP address entries in the SAN extension. This allows connections via IP address when the certificate's SAN contains that IP, without requiring the
hostNameInCertificateworkaround.Changes
SQLServerCertificateUtils.javato handle SAN type 7 (IP Address) entriesSSLCertificateValidationTest.javato verify both DNS and IP address validation