-
Notifications
You must be signed in to change notification settings - Fork 453
[VECTOR_FLOAT16] Implement feature extension and version negotiation for Vector v2 support #2868
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #2868 +/- ##
============================================
+ Coverage 56.44% 56.47% +0.02%
- Complexity 4559 4574 +15
============================================
Files 151 151
Lines 34560 34604 +44
Branches 5768 5774 +6
============================================
+ Hits 19508 19542 +34
- Misses 12418 12439 +21
+ Partials 2634 2623 -11 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
| * @param serverVersion The server's supported vector version | ||
| * @return The negotiated vector version | ||
| */ | ||
| private byte negotiateVectorVersion(String clientVectorSupport, byte serverVersion) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should check and validate connection string value for vectorSupport option as a string only once and then map it to an enum value and use it everywhere instead of string values.
When we send the vector FE to server as part of pre-login, we should compare the connection string value of vectorSupport and driver's current vector version, do the min of it and send that to server. This simplifies trhe negoation.
Description
For upcoming VECTOR_FLOAT16 support in the Microsoft JDBC Driver for SQL Server, this PR introduces the initial framework for vector type support handling on the client side, enabling controlled negotiation of vector capabilities between client and server.
The changes focus on making vector support explicit, extensible, and future-proof, in preparation for additional vector versions and data types.
Vector Version Negotiation Flow
Impact