Skip to content

Conversation

@Javagedes
Copy link
Contributor

Description

The local variable 'WillReturn' was being used without prior initialization in some code paths.
This patch ensures that 'WillReturn' is properly initialized to prevent undefined behavior.

Cherry-pick from EDKII tianocore/edk2@30b6d08

  • Impacts functionality?
  • Impacts security?
  • Breaking change?
  • Includes tests?
  • Includes documentation?

How This Was Tested

Cherry-pick from EDKII tianocore/edk2@30b6d08

Integration Instructions

Cherry-pick from EDKII tianocore/edk2@30b6d08

@github-actions github-actions bot added the impact:non-functional Does not have a functional impact label Sep 23, 2024
@Javagedes Javagedes enabled auto-merge (rebase) September 23, 2024 15:23
@codecov-commenter
Copy link

codecov-commenter commented Sep 23, 2024

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 1.42%. Comparing base (7e30a97) to head (ba1383b).

Files with missing lines Patch % Lines
MdeModulePkg/Core/PiSmmCore/Smi.c 0.00% 1 Missing ⚠️
Additional details and impacted files
@@              Coverage Diff               @@
##           dev/202405    #1153      +/-   ##
==============================================
- Coverage        1.59%    1.42%   -0.17%     
==============================================
  Files            1448     1448              
  Lines          362490   361977     -513     
  Branches         5632     5632              
==============================================
- Hits             5776     5171     -605     
+ Misses         356607   356324     -283     
- Partials          107      482     +375     
Flag Coverage Δ
MdeModulePkg 0.40% <0.00%> (-0.28%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

The local variable 'WillReturn' was being used without prior
initialization in some code paths.
This patch ensures that 'WillReturn' is properly initialized
to prevent undefined behavior.

Signed-off-by: Zhiguang Liu <[email protected]>
@makubacki makubacki added the type:bug Something isn't working label Sep 23, 2024
@Javagedes Javagedes merged commit 36f763d into microsoft:dev/202405 Sep 23, 2024
31 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

impact:non-functional Does not have a functional impact type:bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants