[Rebase & FF] Revert #1106 Clean up history to match release/202405 #1162
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…irmwareVolume2 and AcpiSystemDescriptionTable protocol (microsoft#1106) ## Description Add mock functions under MockUefiLib and Create Mock for AcpiTable, FirmwareVolume2 and AcpiSystemDescriptionTable protocol - [ ] Impacts functionality? - [ ] Impacts security? - [ ] Breaking change? - [x] Includes tests? - [ ] Includes documentation? ## How This Was Tested Unit tests component can call these mock functions success ## Integration Instructions N/A --------- Signed-off-by: dependabot[bot] <[email protected]> Signed-off-by: Ethan Hsu <[email protected]> Signed-off-by: Vivian Nowka-Keane <[email protected]> Signed-off-by: TsunFeng <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Aaron Pop <[email protected]> Co-authored-by: Michael Kubacki <[email protected]> Co-authored-by: Taylor Beebe <[email protected]> Co-authored-by: pohanch <[email protected]> Co-authored-by: kenlautner <[email protected]> Co-authored-by: Oliver Smith-Denny <[email protected]> Co-authored-by: Sean Brogan <[email protected]> Co-authored-by: Aaron <[email protected]> Co-authored-by: yhsu3 <[email protected]> Co-authored-by: Vivian Nowka-Keane <[email protected]> Co-authored-by: v-sbolisetti <[email protected]> Co-authored-by: YiTa-AMI <[email protected]>
…Table, FirmwareVolume2 and AcpiSystemDescriptionTable protocol (microsoft#1106)" This reverts commit 456eada.
github-actions
bot
added
the
impact:non-functional
VivianNK
changed the title
VivianNK
force-pushed
the
personal/vnowkakeane/mocks-revert
branch
from
4cfa08a to
ef53d8b
Compare
VivianNK
changed the title
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev/202405 #1162 +/- ##
===========================================
Coverage 1.59% 1.59%
===========================================
Files 1448 1448
Lines 362501 362491 -10
Branches 5632 5632
===========================================
Hits 5776 5776
+ Misses 356618 356608 -10
Partials 107 107
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
os-d
approved these changes
Sep 26, 2024
apop5
reviewed
Sep 26, 2024
apop5
reviewed
Sep 26, 2024
apop5
requested changes
Sep 26, 2024
VivianNK
changed the title
This reverts commit d74b9cf.
Includes changes across the repo for the following CodeQL rules: - cpp/comparison-with-wider-type - cpp/overflow-buffer - cpp/redundant-null-check-param - cpp/uselesstest Co-authored-by: Taylor Beebe <[email protected]> Co-authored-by: pohanch <[email protected]> Co-authored-by: kenlautner <[email protected]> Co-authored-by: Oliver Smith-Denny <[email protected]> Co-authored-by: Sean Brogan <[email protected]> Co-authored-by: Aaron <[email protected]>
Report PXE error status via Status Code, with this design, it will be flexible to register a status code handler via gEfiRscHandlerProtocolGuid to output the customized error code to other telemetry service. The subclass code is `EFI_IO_BUS_IP_NETWORK` Signed-off-by: Ethan Hsu <[email protected]>
Add mocks from 2405 Cherry picked the following commit: ba672c3 - [ ] Impacts functionality? - [ ] Impacts security? - [ ] Breaking change? - [ ] Includes tests? - [ ] Includes documentation? Tested in 202311 CI N/A Signed-off-by: Vivian Nowka-Keane <[email protected]> Co-authored-by: v-sbolisetti <[email protected]> Co-authored-by: YiTa-AMI <[email protected]>
Description Create mock for AcpiTable, FirmwareVolume2 and AcpiSystemDescriptionTable protocols. Signed-off-by: Vivian Nowka-Keane <[email protected]>
VivianNK
force-pushed
the
personal/vnowkakeane/mocks-revert
branch
from
ef53d8b to
672000f
Compare
VivianNK
changed the title
apop5
approved these changes
Sep 26, 2024
makubacki
force-pushed
the
dev/202405
branch
from
456eada to
a952e84
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
PR #1106 pulled in other commits from release/202405. This reverts the PR's merge commit and cherry-picks the original commits.
How This Was Tested
Tested in release/2311 and dev/202405
Integration Instructions
N/A