Skip to content

Conversation

@kenlautner
Copy link
Contributor

@kenlautner kenlautner commented Mar 6, 2025

Description

In project MU we changed the DEBUG_CLEAR_MEMORY define to do nothing. This causes an issue in the new file MemoryAllocationLibPosix.c which calls it with a newly defined variable. To get around this variable is removed and instead we use what it was deriving its value from instead.

This should be merged with 230503 on a rebase

  • Impacts functionality?
  • Impacts security?
  • Breaking change?
  • Includes tests?
  • Includes documentation?
  • Backport to release branch?

How This Was Tested

Tested on the pipelines. No issues

Integration Instructions

N/A

@github-actions github-actions bot added the impact:non-functional Does not have a functional impact label Mar 6, 2025
@kenlautner kenlautner requested a review from os-d March 7, 2025 01:07
@kenlautner
Copy link
Contributor Author

@os-d are you okay with this type of change surrounding DEBUG_CLEAR_MEMORY or would you rather the macro have dummy functionality so we don't run into this problem in the future?

@os-d
Copy link
Contributor

os-d commented Mar 7, 2025

@os-d are you okay with this type of change surrounding DEBUG_CLEAR_MEMORY or would you rather the macro have dummy functionality so we don't run into this problem in the future?

I think just doing this here for now is okay, if it crops up again, we can look at it further. I would mark this [SQUASH_ON_REBASE] and in the commit message point to 2340503 to be squashed with.

I am starting to get some of the memory protections work upstreamed, so that should hopefully resolve this issue from spreading.

However, we probably have broken the ASAN on tests, or at least part of it, as it seems to be relying on this functionality.

@kenlautner kenlautner changed the title Remove unused variable in DEBUG_CLEAR_MEMORY call [SQUASH_ON_REBASE] Remove unused variable in DEBUG_CLEAR_MEMORY call Mar 10, 2025
@kenlautner kenlautner enabled auto-merge (rebase) March 10, 2025 18:39
@kenlautner kenlautner disabled auto-merge March 10, 2025 18:39
@kenlautner kenlautner enabled auto-merge (squash) March 10, 2025 18:39
@apop5 apop5 disabled auto-merge March 12, 2025 14:55
@apop5 apop5 merged commit 3e41239 into dev/202502 Mar 12, 2025
32 checks passed
@apop5 apop5 deleted the personal/klautner/fix_debug_macro branch March 12, 2025 14:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

impact:non-functional Does not have a functional impact

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants