Skip to content

Conversation

@TsunFengHuang
Copy link
Contributor

@TsunFengHuang TsunFengHuang commented Apr 23, 2025

Description

MdePkg: Add MockSynchronizationLib and MockSmmSxDispatch2

For details on how to complete these options and their meaning refer to CONTRIBUTING.md.

  • Impacts functionality?
  • Impacts security?
  • Breaking change?
  • Includes tests?
  • Includes documentation?
  • Backport to release branch?

How This Was Tested

The mock library and protocol can be consumed success in a Unit test.

Integration Instructions

N/A

@github-actions github-actions bot added impact:non-functional Does not have a functional impact impact:testing Affects testing labels Apr 23, 2025
@TsunFengHuang
Copy link
Contributor Author

@microsoft-github-policy-service agree company="Microsoft"

@TsunFengHuang TsunFengHuang changed the title MdePkg: Add MockSynchronizationLib MdePkg: Add MockSynchronizationLib and MockSmmSxDispatch2 Apr 23, 2025
@codecov-commenter
Copy link

codecov-commenter commented Apr 23, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 1.60%. Comparing base (9744391) to head (857b905).

Additional details and impacted files
@@             Coverage Diff             @@
##           dev/202405    #1340   +/-   ##
===========================================
  Coverage        1.60%    1.60%           
===========================================
  Files            1383     1383           
  Lines          359864   359864           
  Branches         5524     5524           
===========================================
  Hits             5760     5760           
  Misses         353997   353997           
  Partials          107      107           
Flag Coverage Δ
MdeModulePkg 0.67% <ø> (ø)
MdePkg 5.59% <ø> (ø)
NetworkPkg 0.55% <ø> (ø)
PolicyServicePkg 30.41% <ø> (ø)
UefiCpuPkg 4.68% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@TsunFengHuang TsunFengHuang marked this pull request as ready for review April 23, 2025 08:32
@TsunFengHuang TsunFengHuang force-pushed the user/TsunFeng/MockSynchronizationLib branch from 787512f to 14e16b4 Compare April 30, 2025 10:05
@apop5
Copy link
Collaborator

apop5 commented May 2, 2025

Can you please create a PR into EDK2 for these changes? We could like to prevent as many deviations from EDK2 as possible, and creating a PR into EDK2 will help prevent the number of deltas from EDK we have to maintain.

@TsunFengHuang TsunFengHuang force-pushed the user/TsunFeng/MockSynchronizationLib branch from 14e16b4 to ceed9a4 Compare May 5, 2025 10:04
@TsunFengHuang
Copy link
Contributor Author

The PR has been created in EDK II for these changes and is waiting for review.
tianocore/edk2#11034

@github-actions github-actions bot added the type:backport Backport changes in a dev branch PR to its release branch. label May 8, 2025
@apop5 apop5 merged commit 4f2774e into microsoft:dev/202405 May 9, 2025
33 checks passed
apop5 pushed a commit to apop5/mu_basecore that referenced this pull request May 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

impact:non-functional Does not have a functional impact impact:testing Affects testing type:backport Backport changes in a dev branch PR to its release branch.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants