MdeModulePkg/Variable: Move RT cache buffer allocation to DXE #1519
+277
−46
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I was originally planning to take this straight to edk2, but it's needed here now. I'll add |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## release/202502 #1519 +/- ##
=================================================
Coverage ? 1.55%
=================================================
Files ? 636
Lines ? 233935
Branches ? 370
=================================================
Hits ? 3649
Misses ? 230273
Partials ? 13
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
makubacki
force-pushed
the
prevent_variablepei_mem_bucket_fragmentation
branch
from
f2b15aa to
16ac2d6
Compare
Done - |
os-d
approved these changes
Oct 6, 2025
MdeModulePkg/Universal/Variable/RuntimeDxe/VariableSmmRuntimeDxe.c
Outdated
Show resolved
Hide resolved
Commit `d8f513de3e3ef228af7e6facf0ad3e35c3224032` added runtime memory allocation to VariablePei. That will cause runtime memory bucket fragmentation affecting hibernate stability as these runtime allocations are separate from the main runtime memory type bucket allocation made by the DXE Core. To preserve the existing functionality but allow the runtime buffer to come from the DXE bucket, the allocations in PEI are changed to boot services data allocations and the contents are moved to the runtime memory buffers (and those pages unblocked to MM) in the DXE variable driver after the bucket has been allocated by the DXE core. Signed-off-by: Michael Kubacki <[email protected]>
…lure If a RT data buffer fails to be allocated or unblocked, clean up the RT cache state by (1) freeing any allocated buffers and (2) resetting the buffer addresses back to zero to indicate the RT cache is not available. Signed-off-by: Michael Kubacki <[email protected]>
makubacki
force-pushed
the
prevent_variablepei_mem_bucket_fragmentation
branch
from
16ac2d6 to
a88d506
Compare
apop5
approved these changes
Oct 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Commit
d8f513de3e3ef228af7e6facf0ad3e35c3224032(an edk2 commit) added runtime memory allocation to VariablePei. That will cause runtime memory bucket fragmentation affecting hibernate stability as these runtime allocations are separate from the main runtime memory type bucket allocation made by the DXE Core.To preserve the existing functionality but allow the runtime buffer to come from the DXE bucket, the allocations in PEI are changed to boot services data allocations and the contents are moved to the runtime memory buffers (and those pages unblocked to MM) in the DXE variable driver after the bucket has been allocated by the DXE core.
How This Was Tested
Integration Instructions