[CHERRY-PICK] Pick up FFA_RUN solution from EDK2 #1529
Merged
+35
−12
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… as input argument (microsoft#1526)" This reverts commit 1cb266f.
cfernald
approved these changes
Oct 14, 2025
When ArmFfaLibDirectMsgReq(2) is preempted, caller of these functions should resume it works via ArmFfaLibRun() and the secure partition will be return with FFA_DIRECT_MSG_RESP(2) with return arguments. However, since ArmFfaLibRun() gets its return in its stack variable, So caller of ArmFfaLibRun() doesn't get the return arguments from secure partition. To resolve this, add output parameter to ArmFfaLibRun() to receive return arguments. Continuous-integration-options: PatchCheck.ignore-multi-package Fixes: 5d1b38d ("ArmPkg: Add ArmFfaLib used in Dxe driver") Reported-by: Mariam Elshakfy <[email protected]> Signed-off-by: Yeoreum Yun <[email protected]> (cherry picked from commit d8e875e62505e15a48f82ccb49db42be9fda519f)
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## release/202502 #1529 +/- ##
=================================================
Coverage ? 2.22%
=================================================
Files ? 1461
Lines ? 380840
Branches ? 4583
=================================================
Hits ? 8477
Misses ? 372290
Partials ? 73
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
apop5
approved these changes
Oct 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
BASECORE made a change for FFA_RUN change, but EDK2 already has a corresponding change.
This change reverts the original fix and conform to EDK2 version.
For details on how to complete these options and their meaning refer to CONTRIBUTING.md.
How This Was Tested
This was tested on QEMU SBSA and booted to UEFI shell.
Integration Instructions
N/A