Skip to content

Conversation

@eeshanl
Copy link
Contributor

@eeshanl eeshanl commented Nov 3, 2025

Description

Ensures the Snp Structure is initialized as NULL.

cherry-picks back the fix from EDK2

For details on how to complete these options and their meaning refer to CONTRIBUTING.md.

  • Impacts functionality?
  • Impacts security?
  • Breaking change?
  • Includes tests?
  • Includes documentation?

How This Was Tested

Tested on physical device

Integration Instructions

N/A

@eeshanl eeshanl self-assigned this Nov 3, 2025
@eeshanl eeshanl requested review from kuqin12 and os-d November 3, 2025 20:01
@codecov-commenter
Copy link

codecov-commenter commented Nov 3, 2025

Codecov Report

❌ Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.
⚠️ Please upload report for BASE (release/202502@ee61221). Learn more about missing BASE report.

Files with missing lines Patch % Lines
NetworkPkg/SnpDxe/Snp.c 0.00% 2 Missing ⚠️
Additional details and impacted files
@@               Coverage Diff                @@
##             release/202502   #1554   +/-   ##
================================================
  Coverage                  ?   0.55%           
================================================
  Files                     ?     165           
  Lines                     ?   71948           
  Branches                  ?    1750           
================================================
  Hits                      ?     402           
  Misses                    ?   71539           
  Partials                  ?       7           
Flag Coverage Δ
NetworkPkg 0.55% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Contributor

@os-d os-d left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add [CHERRY-PICK] to the commit title

Ensures the Snp Structure is initialized as NULL.

Signed-off-by: Eeshan Londhe <[email protected]>
@eeshanl
Copy link
Contributor Author

eeshanl commented Nov 3, 2025

Please add [CHERRY-PICK] to the commit title

done

@eeshanl eeshanl merged commit defba0f into microsoft:release/202502 Nov 3, 2025
30 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants