[Rebase & FF] Standalone MM IPL fixes #1556
Merged
+90
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ro Pages There could be scenarios where the HOB producer does not create any HOBs. In such cases, the buffer intended to be freed will have zero pages. This update addresses the issue that could cause assertions during runtime by ensuring that buffers with zero pages are not freed. Signed-off-by: Kun Qin <[email protected]> (cherry picked from commit c72d638)
…pen the regions Current MM IPL in PEI phase does not open the MMRAM regions through MM access PPI. This is causing some platforms like OVMF reading all `0xFF`s when trying to relocate the Standalone MM core. This change opens all the MMRAM regions provided by MM access PPI and closes + locks the regions after initial MM foundation setup, when MM Access PPI is available. Platforms that require MM access PPI can inject depex through libraries. Signed-off-by: Kun Qin <[email protected]> (cherry picked from commit 73b0b5e)
apop5
approved these changes
Nov 4, 2025
makubacki
reviewed
Nov 4, 2025
makubacki
reviewed
Nov 4, 2025
StandaloneMmPkg/Drivers/StandaloneMmIplPei/StandaloneMmIplPei.c
Outdated
Show resolved
Hide resolved
makubacki
reviewed
Nov 4, 2025
StandaloneMmPkg/Drivers/StandaloneMmIplPei/StandaloneMmIplPei.c
Outdated
Show resolved
Hide resolved
|
I know this is a cherry-pick but I had a few questions before finishing the review. |
os-d
reviewed
Nov 4, 2025
kuqin12
changed the title
makubacki
approved these changes
Nov 4, 2025
This change adds some logic to handle the MmAccess PPI failure and makes effort to close and lock all regions when possible. Signed-off-by: Kun Qin <[email protected]>
apop5
approved these changes
Nov 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This change cherry-picks 2 commits from EDK2 that could cause some platforms to not work with Standalone MM as expected.
The last commit is an add-on to resolve the feedback on this PR and will be taken to edk2.
How This Was Tested
This was tested on QEMU Q35 platform and booted to Windows desktop.
Integration Instructions
N/A