-
Notifications
You must be signed in to change notification settings - Fork 56
remove pydantic #58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
remove pydantic #58
Conversation
This PR won't work, the entire section related to
Without
This manually set all the attributes. The After this 2 changes this PR will work. (sorry I can't submit a PR myself due to the complicated approval that I'll then need to go through 😢) |
@sbrudz thanks for the review is this ready now? |
@AviAvni The fix you made looks good to me. I'm not a maintainer, though, so @LakshyAAAgrawal will need to answer your question. |
@AviAvni Thank you so much for your PR! Can you please have a look at the failed tests (https://github.com/microsoft/multilspy/actions/runs/13097207670/job/37418751364?pr=58)? Basically, "typing_extensions", which is a dependency of pydantic is still being used many places elsewhere in the repository. So we should try adding it back. @gkorland, @wapiflapi, @camsteffen, @InternetOfTofu, @sbrudz - Thank you so much for your valuable feedback and comments! |
@@ -11,7 +11,7 @@ authors = [ | |||
] | |||
description = "A language-agnostic LSP client in Python, with a library interface. Intended to be used to build applications around language servers. Currently multilspy supports language servers for Python, Rust, Java, Go, JavaScript and C#. Originally appeared as part of Monitor-Guided Decoding (https://github.com/microsoft/monitors4codegen)" | |||
readme = "README.md" | |||
requires-python = ">=3.7" | |||
requires-python = ">=3.8, <4.0" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you kindly undo the "<4.0" change?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
as I wrote if I do it poetry lock command failed with
For jedi-language-server, a possible solution would be to set the python
property to ">=3.8,<4.0"
@AviAvni, I am very sorry for being so picky on this, but I want to ensure multilspy can be runnable in as many configurations and environments as possible (which is why we are removing pydantic in the first place), so I apologize for being picky, and request you to make the changes as I requested above if you think they are right! |
I also want to note that, at the moment, there's nothing except the |
Dear @sternj, Thank you very much for bringing this to notice. Overall I think since we are already able to contain the usage of pydantic, it may be better to do away with a dependency? |
@LakshyAAAgrawal Given that it's approved now that definitely makes more sense! I was just suggesting a quick and dirty fix to satiate our dependency resolvers while the maintainers put in place a real solution! There is one now, which is far better than my idea. |
Thank you so much @AviAvni for the contribution, and to everyone for their comments and feedback! |
Fix #55