Skip to content

Add psutil dependency and enhance process termination handling #67

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

v4rgas
Copy link
Contributor

@v4rgas v4rgas commented Feb 28, 2025

Sometimes, when OmniSharp hangs, it leaves a RazorSharp process running. This PR ensures that the child processes are also terminated

@LakshyAAAgrawal
Copy link
Collaborator

Good catch! And thanks for opening the PR

@v4rgas
Copy link
Contributor Author

v4rgas commented Feb 28, 2025

thank you! i noticed this because it started consuming all the ram of my server, omnisharp likes to crash a lot lol

@LakshyAAAgrawal LakshyAAAgrawal merged commit 47b7f06 into microsoft:main Feb 28, 2025
4 checks passed
@v4rgas v4rgas deleted the feat/missing-children-termination branch March 10, 2025 03:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants