fix: resolve 'No module named pwd' error on Windows #70
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@microsoft-github-policy-service agree |
LakshyAAAgrawal
requested changes
Mar 1, 2025
src/multilspy/language_servers/typescript_language_server/typescript_language_server.py
Outdated
Show resolved
Hide resolved
|
Great catch, and thanks a lot for the PR! |
LakshyAAAgrawal
approved these changes
Mar 2, 2025
LakshyAAAgrawal
approved these changes
Mar 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using the TypeScriptLanguageServer on Windows environments, users encounter a No module named 'pwd' error.
This occurs because the pwd module is only available on Unix-like systems but was being imported unconditionally.
This PR adds a conditional import for the pwd module that only executes on non-Windows platforms.