Skip to content

Added Failing Test For TS Language Server with Cross File Definitions… - #81

Merged
Lakshya A Agrawal (LakshyAAAgrawal) merged 6 commits into
microsoft:mainfrom
agoel111:ts_fail_tests
Apr 13, 2026
Merged

Added Failing Test For TS Language Server with Cross File Definitions…#81
Lakshya A Agrawal (LakshyAAAgrawal) merged 6 commits into
microsoft:mainfrom
agoel111:ts_fail_tests

Conversation

@agoel111

@agoel111 agoel111 commented Mar 8, 2025

Copy link
Copy Markdown
Contributor

The TS Language servers' response doesn't work with definitions or references to methods of classes across different files.
It is written with reference to #78.

@LakshyAAAgrawal

Copy link
Copy Markdown
Collaborator

Hi agoel111
Thank you so much for the PRs you have kindly created.

At the moment the unit tests are failing. This is due to some external issue in the unit tests, which I have fixed in the latest commit to main branch.
Could you please merge/rebase on top of main branch to get the unit tests in the CI working again, after which I will review and merge the PR.

Could you please do this for all your branches?

@agoel111

Copy link
Copy Markdown
Contributor Author

agoel111 please read the following Contributor License Agreement(CLA). If you agree with the CLA, please reply with the following information.

@microsoft-github-policy-service agree [company="{your company}"]

Options:

  • (default - no company specified) I have sole ownership of intellectual property rights to my Submissions and I am not making Submissions in the course of work for my employer.
@microsoft-github-policy-service agree
  • (when company given) I am making Submissions in the course of work for my employer (or my employer has intellectual property rights in my Submissions by contract or applicable law). I have permission from my employer to make Submissions and enter into this Agreement on behalf of my employer. By signing below, the defined term “You” includes me and my employer.
@microsoft-github-policy-service agree company="Microsoft"

Contributor License Agreement

@microsoft-github-policy-service agree

@agoel111

Copy link
Copy Markdown
Contributor Author

Lakshya A Agrawal (@LakshyAAAgrawal) Kindly the desired changes. It should be good now!

@LakshyAAAgrawal
Lakshya A Agrawal (LakshyAAAgrawal) merged commit b8d87e0 into microsoft:main Apr 13, 2026
9 of 10 checks passed
@LakshyAAAgrawal

Copy link
Copy Markdown
Collaborator

Thank you very much for your contribution agoel111!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants