Skip to content

Bump jedi-language-server to 0.41.3 to support textDocument/declaration #88

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 28, 2025

Conversation

Andrej730
Copy link
Contributor

@LakshyAAAgrawal
Copy link
Collaborator

Hi @Andrej730 Thank you so much for all the PRs you have kindly created.

At the moment the unit tests are failing. This is due to some external issue in the unit tests, which I have fixed in the latest commit to main branch.
Could you please merge/rebase on top of main branch to get the unit tests in the CI working again, after which I will review and merge the PR.

Could you please do this for all your PRs?

@Andrej730
Copy link
Contributor Author

@LakshyAAAgrawal rebased prs.

@LakshyAAAgrawal
Copy link
Collaborator

The PR looks great. Could you potentially add a unittest case asking for the textDocument/declaration request and ensuring it works?

@Andrej730
Copy link
Contributor Author

The PR looks great. Could you potentially add a unittest case asking for the textDocument/declaration request and ensuring it works?

@LakshyAAAgrawa
But does this kind of unittest make sense in the context of this PR? Since there's no high level declaration method (e.g. no request_declaration) and there also a few of other jedi method that are not test-covered (https://github.com/pappasam/jedi-language-server#language-features).
I think it would make sense as a separate thing to this pr, as a more of a general low level api test, similar to something I've mentioned in #89

@LakshyAAAgrawal
Copy link
Collaborator

Agreed. Merging now!

@LakshyAAAgrawal LakshyAAAgrawal merged commit db80914 into microsoft:main Mar 28, 2025
4 checks passed
@Andrej730 Andrej730 deleted the bump-jedi branch March 28, 2025 04:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants