Move CI/CD to windows-2025 for VS 2026#357
Open
nmlud21 wants to merge 9 commits into
Open
Conversation
Signed-off-by: Nicholas Ludwig <nludwig@microsoft.com>
nmlud21
requested review from
Alan-Jowett,
LakshK98,
matthewige,
mikeagun,
mtfriesen,
poornagmsft,
saxena-anurag and
shankarseal
as code owners
June 30, 2026 18:31
Signed-off-by: Nicholas Ludwig <nludwig@microsoft.com>
Signed-off-by: Nicholas Ludwig <nludwig@microsoft.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
added 2 commits
July 1, 2026 10:29
Signed-off-by: Nicholas Ludwig <nludwig@microsoft.com>
…into CI-vs-2026
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 19 out of 19 changed files in this pull request and generated 2 comments.
Comments suppressed due to low confidence (1)
scripts/setup_build/setup_build.vcxproj:112
- Same issue here: using
xcopy /Dcan skip copying when switching between MSVC toolsets/WDK versions, leaving a stale CRT in$(OutDir)and making the produced binaries non-reproducible. Always overwrite the staged CRT files for the active toolset.
for /d %%d in ("$(VC_CppRuntimeFilesPath_x64)\Microsoft.VC*.CRT") do xcopy /D /Y "%%d\*" "$(OutDir)"
| <Command>powershell -NonInteractive -ExecutionPolicy Unrestricted $(SolutionDir)scripts\copy_pre_commit.ps1 $(SolutionDir)scripts\pre-commit | ||
| powershell -NonInteractive -ExecutionPolicy Unrestricted $(SolutionDir)scripts\generate-commitid.ps1 $(SolutionDir)\include | ||
| copy "$(VC_DebugCppRuntimeFilesPath_x64)\Microsoft.VC143.DebugCRT\*" "$(OutDir)" | ||
| for /d %%d in ("$(VC_DebugCppRuntimeFilesPath_x64)\Microsoft.VC*.DebugCRT") do xcopy /D /Y "%%d\*" "$(OutDir)" |
Comment on lines
+118
to
+123
| <!-- C28285 is disabled (downgraded to Warning) because the Code Analysis engine (VS2026 / | ||
| SDK 10.0.28000) reports a spurious "syntax error in SAL_range" while parsing compiler-internal | ||
| intrinsic declarations such as _BitScanForward (SAL_range(0,(sizeof(Mask)*8)-1)). The diagnostic | ||
| fires in "predefined c++ types (compiler internal)", not in our source, so it is a non-actionable | ||
| false positive. Re-enable (Action="Error") once the analysis engine parses these annotations. --> | ||
| <Rule Id="C28285" Action="Warning" /> |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The goal of this PR is to move the CI/CD pipeline to windows-2025 for VS 2026 support and WDK version 28000.
This follows the same patterns as microsoft/ebpf-for-windows#5257
Resolves #353
Testing
Successful build and CI/CD passes.
Documentation
No
Installation
No